[linux-next:master 3963/4921] arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared; did you mean 'proc_ops'?

[linux-next:master 3963/4921] arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared; did you mean 'proc_ops'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9606f9efb1cec7f8f5912326f182fbfbcad34382
commit: aad102cc51173ded2de33a5cae26ace158de5617 [3963/4921] proc: Make the proc_create[_data]() stubs static inlines
config: sparc-randconfig-r034-20211202 (https://download.01.org/0day-ci/archive/20211202/202112021611.fSXit1xd-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=aad102cc51173ded2de33a5cae26ace158de5617
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout aad102cc51173ded2de33a5cae26ace158de5617
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash arch/sparc/kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/sparc/kernel/led.c: In function 'led_init':
>> arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared (first use in this function); did you mean 'proc_ops'?
     125 |         led = proc_create("led", 0, NULL, &led_proc_ops);
         |                                            ^~~~~~~~~~~~
         |                                            proc_ops
   arch/sparc/kernel/led.c:125:44: note: each undeclared identifier is reported only once for each function it appears in


vim +125 arch/sparc/kernel/led.c

ee1858d3122ded Lars Kotthoff   2005-11-07  120  
ee1858d3122ded Lars Kotthoff   2005-11-07  121  static int __init led_init(void)
ee1858d3122ded Lars Kotthoff   2005-11-07  122  {
db275f2a02cd35 Kees Cook       2017-10-09  123  	timer_setup(&led_blink_timer, led_blink, 0);
ee1858d3122ded Lars Kotthoff   2005-11-07  124  
97a32539b9568b Alexey Dobriyan 2020-02-03 @125  	led = proc_create("led", 0, NULL, &led_proc_ops);
ee1858d3122ded Lars Kotthoff   2005-11-07  126  	if (!led)
ee1858d3122ded Lars Kotthoff   2005-11-07  127  		return -ENOMEM;
ee1858d3122ded Lars Kotthoff   2005-11-07  128  
ee1858d3122ded Lars Kotthoff   2005-11-07  129  	printk(KERN_INFO
ee1858d3122ded Lars Kotthoff   2005-11-07  130  	       "led: version %s, Lars Kotthoff <metalhead@metalhead.ws>\n",
ee1858d3122ded Lars Kotthoff   2005-11-07  131  	       LED_VERSION);
ee1858d3122ded Lars Kotthoff   2005-11-07  132  
ee1858d3122ded Lars Kotthoff   2005-11-07  133  	return 0;
ee1858d3122ded Lars Kotthoff   2005-11-07  134  }
ee1858d3122ded Lars Kotthoff   2005-11-07  135  

:::::: The code at line 125 was first introduced by commit
:::::: 97a32539b9568bb653683349e5a76d02ff3c3e2c proc: convert everything to "struct proc_ops"

:::::: TO: Alexey Dobriyan <adobriyan@gmail.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Re: [linux-next:master 3963/4921] arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared; did you mean 'proc_ops'?

[Andrew Morton]

On Thu, 2 Dec 2021 17:03:39 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   9606f9efb1cec7f8f5912326f182fbfbcad34382
> commit: aad102cc51173ded2de33a5cae26ace158de5617 [3963/4921] proc: Make the proc_create[_data]() stubs static inlines
> config: sparc-randconfig-r034-20211202 (https://download.01.org/0day-ci/archive/20211202/202112021611.fSXit1xd-lkp@intel.com/config)
> compiler: sparc-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=aad102cc51173ded2de33a5cae26ace158de5617
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout aad102cc51173ded2de33a5cae26ace158de5617
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash arch/sparc/kernel/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/sparc/kernel/led.c: In function 'led_init':
> >> arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared (first use in this function); did you mean 'proc_ops'?
>      125 |         led = proc_create("led", 0, NULL, &led_proc_ops);
>          |                                            ^~~~~~~~~~~~
>          |                                            proc_ops
>    arch/sparc/kernel/led.c:125:44: note: each undeclared identifier is reported only once for each function it appears in

Thanks.  I did this.

--- a/arch/sparc/kernel/led.c~proc-make-the-proc_create-stubs-static-inlines-fix2
+++ a/arch/sparc/kernel/led.c
@@ -122,10 +122,11 @@ static int __init led_init(void)
 {
 	timer_setup(&led_blink_timer, led_blink, 0);
 
+#ifdef CONFIG_PROC_FS
 	led = proc_create("led", 0, NULL, &led_proc_ops);
 	if (!led)
 		return -ENOMEM;
-
+#endif
 	printk(KERN_INFO
 	       "led: version %s, Lars Kotthoff <metalhead@metalhead.ws>\n",
 	       LED_VERSION);
_