From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAEF7C433F5 for ; Thu, 2 Dec 2021 23:08:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 504646B0072; Thu, 2 Dec 2021 18:08:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B31F6B0074; Thu, 2 Dec 2021 18:08:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37A446B0075; Thu, 2 Dec 2021 18:08:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 283D56B0072 for ; Thu, 2 Dec 2021 18:08:08 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DAF1E8A9D3 for ; Thu, 2 Dec 2021 23:07:57 +0000 (UTC) X-FDA: 78874393794.25.D22CBDD Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id 48392D000099 for ; Thu, 2 Dec 2021 23:07:57 +0000 (UTC) Received: from mail.kernel.org (unknown [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 76DEFB823BC; Thu, 2 Dec 2021 23:07:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 971CB60720; Thu, 2 Dec 2021 23:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1638486473; bh=bvRZ2UqEN7LaJEGWnjyrWJXzFZlQQMv4pOPQjWRDcJ4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HoG2NbFcmuZX39yME8uY1AFm7AARn/yfi50KKBr5nlga0lYAYrA9PK/5yDU+fwHMl gr0BnIGmitKjWB3x6TNgFoWJmxvboZZGeyvLhRq34FFzj5HZLZPdu8+xqchEzd3PKq NZrcLSvKuN4C/ZaHdGhNUTCWk9DiLUiI9Zjf5Clc= Date: Thu, 2 Dec 2021 15:07:51 -0800 From: Andrew Morton To: kernel test robot Cc: Hans de Goede , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 3963/4921] arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared; did you mean 'proc_ops'? Message-Id: <20211202150751.df3d93cf753b39e4bfed0462@linux-foundation.org> In-Reply-To: <202112021611.fSXit1xd-lkp@intel.com> References: <202112021611.fSXit1xd-lkp@intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 48392D000099 X-Stat-Signature: pucmecw1h4wxhghqskco1ak6ftyrysks Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=HoG2NbFc; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1638486477-13741 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2 Dec 2021 17:03:39 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 9606f9efb1cec7f8f5912326f182fbfbcad34382 > commit: aad102cc51173ded2de33a5cae26ace158de5617 [3963/4921] proc: Make the proc_create[_data]() stubs static inlines > config: sparc-randconfig-r034-20211202 (https://download.01.org/0day-ci/archive/20211202/202112021611.fSXit1xd-lkp@intel.com/config) > compiler: sparc-linux-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=aad102cc51173ded2de33a5cae26ace158de5617 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout aad102cc51173ded2de33a5cae26ace158de5617 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash arch/sparc/kernel/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > arch/sparc/kernel/led.c: In function 'led_init': > >> arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared (first use in this function); did you mean 'proc_ops'? > 125 | led = proc_create("led", 0, NULL, &led_proc_ops); > | ^~~~~~~~~~~~ > | proc_ops > arch/sparc/kernel/led.c:125:44: note: each undeclared identifier is reported only once for each function it appears in Thanks. I did this. --- a/arch/sparc/kernel/led.c~proc-make-the-proc_create-stubs-static-inlines-fix2 +++ a/arch/sparc/kernel/led.c @@ -122,10 +122,11 @@ static int __init led_init(void) { timer_setup(&led_blink_timer, led_blink, 0); +#ifdef CONFIG_PROC_FS led = proc_create("led", 0, NULL, &led_proc_ops); if (!led) return -ENOMEM; - +#endif printk(KERN_INFO "led: version %s, Lars Kotthoff \n", LED_VERSION); _