From: Andrew Morton <akpm@linux-foundation.org>
To: kernel test robot <lkp@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 3963/4921] arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared; did you mean 'proc_ops'?
Date: Thu, 2 Dec 2021 15:07:51 -0800 [thread overview]
Message-ID: <20211202150751.df3d93cf753b39e4bfed0462@linux-foundation.org> (raw)
In-Reply-To: <202112021611.fSXit1xd-lkp@intel.com>
On Thu, 2 Dec 2021 17:03:39 +0800 kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 9606f9efb1cec7f8f5912326f182fbfbcad34382
> commit: aad102cc51173ded2de33a5cae26ace158de5617 [3963/4921] proc: Make the proc_create[_data]() stubs static inlines
> config: sparc-randconfig-r034-20211202 (https://download.01.org/0day-ci/archive/20211202/202112021611.fSXit1xd-lkp@intel.com/config)
> compiler: sparc-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=aad102cc51173ded2de33a5cae26ace158de5617
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout aad102cc51173ded2de33a5cae26ace158de5617
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash arch/sparc/kernel/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> arch/sparc/kernel/led.c: In function 'led_init':
> >> arch/sparc/kernel/led.c:125:44: error: 'led_proc_ops' undeclared (first use in this function); did you mean 'proc_ops'?
> 125 | led = proc_create("led", 0, NULL, &led_proc_ops);
> | ^~~~~~~~~~~~
> | proc_ops
> arch/sparc/kernel/led.c:125:44: note: each undeclared identifier is reported only once for each function it appears in
Thanks. I did this.
--- a/arch/sparc/kernel/led.c~proc-make-the-proc_create-stubs-static-inlines-fix2
+++ a/arch/sparc/kernel/led.c
@@ -122,10 +122,11 @@ static int __init led_init(void)
{
timer_setup(&led_blink_timer, led_blink, 0);
+#ifdef CONFIG_PROC_FS
led = proc_create("led", 0, NULL, &led_proc_ops);
if (!led)
return -ENOMEM;
-
+#endif
printk(KERN_INFO
"led: version %s, Lars Kotthoff <metalhead@metalhead.ws>\n",
LED_VERSION);
_
prev parent reply other threads:[~2021-12-02 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:03 kernel test robot
2021-12-02 23:07 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202150751.df3d93cf753b39e4bfed0462@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox