From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Leon Romanovsky <leon@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Bixuan Cui <cuibixuan@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, w@1wt.eu
Subject: Re: [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc() calls
Date: Thu, 2 Dec 2021 14:03:43 -0800 [thread overview]
Message-ID: <20211202140343.0fd5dbc41513b1c95661ff8f@linux-foundation.org> (raw)
In-Reply-To: <202112021320.87AB40A@keescook>
On Thu, 2 Dec 2021 13:23:13 -0800 Kees Cook <keescook@chromium.org> wrote:
> > > I think we have two cases:
> > >
> > > - limiting kvmalloc allocations to INT_MAX
> > > - issuing a WARN when that limit is exceeded
> > >
> > > The argument for the having the WARN is "that amount should never be
> > > allocated so we want to find the pathological callers".
> > >
> > > But if the actual issue is that >INT_MAX is _acceptable_, then we have
> > > to do away with the entire check, not just the WARN.
> >
> > First we need to get rid from WARN_ON(), which is completely safe thing to do.
> >
> > Removal of the check can be done in second step as it will require audit
> > of whole kvmalloc* path.
>
> If those are legit sizes, I'm fine with dropping the WARN. (But I still
> think if they're legit sizes, we must also drop the INT_MAX limit.)
Can we suppress the WARN if the caller passed __GFP_NOWARN?
next prev parent reply other threads:[~2021-12-02 22:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 2:06 Bixuan Cui
2021-12-02 2:53 ` Tang Yizhou
2021-12-02 3:26 ` Andrew Morton
2021-12-02 4:05 ` Bixuan Cui
2021-12-02 4:29 ` Andrew Morton
2021-12-02 10:38 ` Jeremy Sowden
2021-12-02 15:34 ` Alexei Starovoitov
2021-12-02 21:16 ` Jeremy Sowden
2021-12-02 11:49 ` Bixuan Cui
2021-12-03 19:37 ` Sean Christopherson
2021-12-02 15:23 ` Leon Romanovsky
2021-12-02 15:29 ` Matthew Wilcox
2021-12-02 16:08 ` Leon Romanovsky
2021-12-02 19:08 ` Kees Cook
2021-12-02 19:24 ` Leon Romanovsky
2021-12-02 21:23 ` Kees Cook
2021-12-02 22:03 ` Andrew Morton [this message]
2021-12-03 4:39 ` Matthew Wilcox
2021-12-02 17:00 ` Jason Gunthorpe
2021-12-02 3:46 ` Kees Cook
2021-12-02 4:44 ` Bixuan Cui
2021-12-02 17:03 ` Jason Gunthorpe
2021-12-05 11:59 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202140343.0fd5dbc41513b1c95661ff8f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cuibixuan@linux.alibaba.com \
--cc=keescook@chromium.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox