From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81078C433F5 for ; Wed, 1 Dec 2021 18:17:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B54646B0082; Wed, 1 Dec 2021 13:15:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 708F56B0085; Wed, 1 Dec 2021 13:15:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1661C6B007D; Wed, 1 Dec 2021 13:15:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id CFAD86B0072 for ; Wed, 1 Dec 2021 13:15:27 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 92C508088E for ; Wed, 1 Dec 2021 18:15:17 +0000 (UTC) X-FDA: 78870027474.19.A87CC57 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf14.hostedemail.com (Postfix) with ESMTP id 2A37C6001995 for ; Wed, 1 Dec 2021 18:15:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 192162171F; Wed, 1 Dec 2021 18:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1638382516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3dn7x4vAO7A1NDlfRW2lr8zvnjRIzRGSYuX8+ae7iAw=; b=0RjmnZeJwhmoZCijBqgn7s55f1ORRMuTNF7tH9pmfvdQBcWS7cs+VdCo4y7H1QVEqJPKxW jTJvR30UwJAs9cOHBlzlPQmVmpxmxmKuSSf7AzfYjAH9KKXsPu3abvS35RceTBDaFb7lV3 tpZIus1KWB+2/ESM5uIZx/P8YWJEHK8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1638382516; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3dn7x4vAO7A1NDlfRW2lr8zvnjRIzRGSYuX8+ae7iAw=; b=+iIhENglwph2PLRFkViBe7s8myIKJm9sTTP/rJPN2mqhmg5fWCk0D4w35w+hrmWYb+C4L0 QTItZwLnwxytdoCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E44FE14050; Wed, 1 Dec 2021 18:15:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WKQrN7O7p2HPSAAAMHmgww (envelope-from ); Wed, 01 Dec 2021 18:15:15 +0000 From: Vlastimil Babka To: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg Cc: linux-mm@kvack.org, Andrew Morton , patches@lists.linux.dev, Vlastimil Babka Subject: [PATCH v2 05/33] mm: Add account_slab() and unaccount_slab() Date: Wed, 1 Dec 2021 19:14:42 +0100 Message-Id: <20211201181510.18784-6-vbabka@suse.cz> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211201181510.18784-1-vbabka@suse.cz> References: <20211201181510.18784-1-vbabka@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3391; i=vbabka@suse.cz; h=from:subject; bh=PBR+3dbetbQkpEh/4DBavtsNZubPZd2KOiUPTRmMTnw=; b=owEBbQGS/pANAwAIAeAhynPxiakQAcsmYgBhp7tofxgN90NPg9aRllNVe7iImBbARlWku9YYX0pv Am0IZMiJATMEAAEIAB0WIQSNS5MBqTXjGL5IXszgIcpz8YmpEAUCYae7aAAKCRDgIcpz8YmpELrFB/ 4slbsUOsTLbCVOummpScvgifsVJhFxG52kDmIwrLbIdF0aK4SJBygpWj/EVTqnR0tSx/OAkKuvgVLU TyKLBDwj3qKLQfEnpD8YMLzKykFBJOW5+z0h1JcDM2yvjZyYV0IX4/+lsMdGqySDbuyrOEigHdWaJ3 KdGPGMTzJxf/9GWJnRmhs8CqkXyfYJemC1IHSv37Q5Vfbhu1k6kDzt/9ozF0kdypzP3S7aQgcZrstk kdJMAK4jD9gf4zebLGETQPrvPKH/CKXHOhQ6HxJEhFnS/Y7Th3BKluDg3ulsey1ex0QK/HQE7jWiqN k7KejnQqjiGeRKa28Dr5N0aGelglh4 X-Developer-Key: i=vbabka@suse.cz; a=openpgp; fpr=A940D434992C2E8E99103D50224FA7E7CC82A664 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2A37C6001995 X-Stat-Signature: webpfn6n1dui14a7qikmeezayy3dws7s Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0RjmnZeJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+iIhENgl; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-HE-Tag: 1638382516-698991 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" These functions take struct slab instead of struct page and replace (un)account_slab_page(). For now their callers just convert page to slab. [ vbabka@suse.cz: replace existing functions instead of calling them ] Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Vlastimil Babka --- mm/slab.c | 4 ++-- mm/slab.h | 17 ++++++++--------- mm/slub.c | 4 ++-- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index 381875e23277..7f147805d0ab 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -1380,7 +1380,7 @@ static struct page *kmem_getpages(struct kmem_cache= *cachep, gfp_t flags, return NULL; } =20 - account_slab_page(page, cachep->gfporder, cachep, flags); + account_slab(page_slab(page), cachep->gfporder, cachep, flags); __SetPageSlab(page); /* Record if ALLOC_NO_WATERMARKS was set when allocating the slab */ if (sk_memalloc_socks() && page_is_pfmemalloc(page)) @@ -1405,7 +1405,7 @@ static void kmem_freepages(struct kmem_cache *cache= p, struct page *page) =20 if (current->reclaim_state) current->reclaim_state->reclaimed_slab +=3D 1 << order; - unaccount_slab_page(page, order, cachep); + unaccount_slab(page_slab(page), order, cachep); __free_pages(page, order); } =20 diff --git a/mm/slab.h b/mm/slab.h index 0e67a8cb7f80..dd3f72fddff6 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -583,24 +583,23 @@ static inline struct kmem_cache *virt_to_cache(cons= t void *obj) return page->slab_cache; } =20 -static __always_inline void account_slab_page(struct page *page, int ord= er, - struct kmem_cache *s, - gfp_t gfp) +static __always_inline void account_slab(struct slab *slab, int order, + struct kmem_cache *s, gfp_t gfp) { if (memcg_kmem_enabled() && (s->flags & SLAB_ACCOUNT)) - memcg_alloc_page_obj_cgroups(page, s, gfp, true); + memcg_alloc_page_obj_cgroups(slab_page(slab), s, gfp, true); =20 - mod_node_page_state(page_pgdat(page), cache_vmstat_idx(s), + mod_node_page_state(slab_pgdat(slab), cache_vmstat_idx(s), PAGE_SIZE << order); } =20 -static __always_inline void unaccount_slab_page(struct page *page, int o= rder, - struct kmem_cache *s) +static __always_inline void unaccount_slab(struct slab *slab, int order, + struct kmem_cache *s) { if (memcg_kmem_enabled()) - memcg_free_page_obj_cgroups(page); + memcg_free_page_obj_cgroups(slab_page(slab)); =20 - mod_node_page_state(page_pgdat(page), cache_vmstat_idx(s), + mod_node_page_state(slab_pgdat(slab), cache_vmstat_idx(s), -(PAGE_SIZE << order)); } =20 diff --git a/mm/slub.c b/mm/slub.c index 4776bcc8c9e4..8b172de26c67 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1943,7 +1943,7 @@ static struct page *allocate_slab(struct kmem_cache= *s, gfp_t flags, int node) =20 page->objects =3D oo_objects(oo); =20 - account_slab_page(page, oo_order(oo), s, flags); + account_slab(page_slab(page), oo_order(oo), s, flags); =20 page->slab_cache =3D s; __SetPageSlab(page); @@ -2014,7 +2014,7 @@ static void __free_slab(struct kmem_cache *s, struc= t page *page) page->slab_cache =3D NULL; if (current->reclaim_state) current->reclaim_state->reclaimed_slab +=3D pages; - unaccount_slab_page(page, order, s); + unaccount_slab(page_slab(page), order, s); __free_pages(page, order); } =20 --=20 2.33.1