From: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
Subject: [PATCH] mm: fix the type of a parameter
Date: Thu, 2 Dec 2021 02:12:36 +0800 [thread overview]
Message-ID: <20211201181236.2315-1-caoyixuan2019@email.szu.edu.cn> (raw)
The type of "last_migrate_reason" in struct page_owner is short.
However, the type of "reason" in the argument list of following functions
__set_page_owner_migrate_reason
set_page_owner_migrate_reason
is int, which is inconsistent.
Signed-off-by: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>
---
include/linux/page_owner.h | 6 +++---
mm/page_owner.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h
index 119a0c9d2a8b..c537315ec02f 100644
--- a/include/linux/page_owner.h
+++ b/include/linux/page_owner.h
@@ -13,7 +13,7 @@ extern void __set_page_owner(struct page *page,
unsigned short order, gfp_t gfp_mask);
extern void __split_page_owner(struct page *page, unsigned int nr);
extern void __folio_copy_owner(struct folio *newfolio, struct folio *old);
-extern void __set_page_owner_migrate_reason(struct page *page, int reason);
+extern void __set_page_owner_migrate_reason(struct page *page, short reason);
extern void __dump_page_owner(const struct page *page);
extern void pagetypeinfo_showmixedcount_print(struct seq_file *m,
pg_data_t *pgdat, struct zone *zone);
@@ -41,7 +41,7 @@ static inline void folio_copy_owner(struct folio *newfolio, struct folio *old)
if (static_branch_unlikely(&page_owner_inited))
__folio_copy_owner(newfolio, old);
}
-static inline void set_page_owner_migrate_reason(struct page *page, int reason)
+static inline void set_page_owner_migrate_reason(struct page *page, short reason)
{
if (static_branch_unlikely(&page_owner_inited))
__set_page_owner_migrate_reason(page, reason);
@@ -66,7 +66,7 @@ static inline void split_page_owner(struct page *page,
static inline void folio_copy_owner(struct folio *newfolio, struct folio *folio)
{
}
-static inline void set_page_owner_migrate_reason(struct page *page, int reason)
+static inline void set_page_owner_migrate_reason(struct page *page, short reason)
{
}
static inline void dump_page_owner(const struct page *page)
diff --git a/mm/page_owner.c b/mm/page_owner.c
index 4f924957ce7a..4c23e910caf9 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -182,7 +182,7 @@ noinline void __set_page_owner(struct page *page, unsigned short order,
__set_page_owner_handle(page_ext, handle, order, gfp_mask);
}
-void __set_page_owner_migrate_reason(struct page *page, int reason)
+void __set_page_owner_migrate_reason(struct page *page, short reason)
{
struct page_ext *page_ext = lookup_page_ext(page);
struct page_owner *page_owner;
--
2.31.1
.
next reply other threads:[~2021-12-01 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 18:12 Yixuan Cao [this message]
2021-12-02 3:34 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2021-11-25 19:43 Yixuan Cao
2021-11-25 20:28 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201181236.2315-1-caoyixuan2019@email.szu.edu.cn \
--to=caoyixuan2019@email.szu.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox