From: Vladimir Murzin <vladimir.murzin@arm.com>
To: linux-arch-owner@vger.kernel.org, linux-mm@kvack.org
Cc: dennis@kernel.org, tj@kernel.org, cl@linux.com,
akpm@linux-foundation.org, npiggin@gmail.com, hch@lst.de,
arnd@arndb.de, vladimir.murzin@arm.com
Subject: [PATCH] percpu: km: ensure it is used with NOMMU (either UP or SMP)
Date: Tue, 30 Nov 2021 17:29:54 +0000 [thread overview]
Message-ID: <20211130172954.129587-2-vladimir.murzin@arm.com> (raw)
In-Reply-To: <20211130172954.129587-1-vladimir.murzin@arm.com>
Currently, NOMMU pull km allocator via !SMP dependency because most of
them are UP, yet for SMP+NOMMU vm allocator gets pulled which:
* may lead to broken build [1]
* ...or not working runtime due to [2]
It looks like SMP+NOMMU case was overlooked in bbddff054587 ("percpu:
use percpu allocator on UP too") so restore that.
[1]
For ARM SMP+NOMMU (R-class cores)
arm-none-linux-gnueabihf-ld: mm/percpu.o: in function `pcpu_post_unmap_tlb_flush':
mm/percpu-vm.c:188: undefined reference to `flush_tlb_kernel_range'
[2]
static inline
int vmap_pages_range_noflush(unsigned long addr, unsigned long end,
pgprot_t prot, struct page **pages, unsigned int page_shift)
{
return -EINVAL;
}
Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
---
mm/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/Kconfig b/mm/Kconfig
index d16ba92..66331e0 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -425,9 +425,8 @@ config THP_SWAP
# UP and nommu archs use km based percpu allocator
#
config NEED_PER_CPU_KM
- depends on !SMP
bool
- default y
+ default !SMP || !MMU
config CLEANCACHE
bool "Enable cleancache driver to cache clean pages if tmem is present"
--
2.7.4
next prev parent reply other threads:[~2021-11-30 17:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 17:29 [PATCH] percpu: km: Use for SMP+NOMMU Vladimir Murzin
2021-11-30 17:29 ` Vladimir Murzin [this message]
2021-11-30 17:41 ` [PATCH] percpu: km: ensure it is used with NOMMU (either UP or SMP) Dennis Zhou
2021-12-01 11:51 ` Vladimir Murzin
2021-12-03 21:02 ` Dennis Zhou
2021-12-06 8:27 ` Vladimir Murzin
2021-12-06 12:01 ` Rob Landley
2021-12-06 16:21 ` Rich Felker
2021-12-06 17:54 ` Dennis Zhou
2021-12-14 16:29 ` Geert Uytterhoeven
2021-12-14 17:26 ` Dennis Zhou
2021-12-14 19:02 ` Geert Uytterhoeven
2021-12-14 19:18 ` Dennis Zhou
2021-12-14 20:12 ` Geert Uytterhoeven
2021-12-14 20:50 ` Dennis Zhou
2021-12-15 7:56 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130172954.129587-2-vladimir.murzin@arm.com \
--to=vladimir.murzin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=hch@lst.de \
--cc=linux-arch-owner@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox