From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AD65C433F5 for ; Mon, 29 Nov 2021 20:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F03E86B0074; Mon, 29 Nov 2021 15:36:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB2966B0075; Mon, 29 Nov 2021 15:36:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7A576B0078; Mon, 29 Nov 2021 15:36:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id C84156B0074 for ; Mon, 29 Nov 2021 15:36:51 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 83A6F8908F for ; Mon, 29 Nov 2021 20:36:41 +0000 (UTC) X-FDA: 78863126202.21.907A57E Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 655F630000BA for ; Mon, 29 Nov 2021 20:36:36 +0000 (UTC) Received: from dfw.source.kernel.org (pac-dfw-korg-source-1.fe.codeaurora.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A8ACACE16B9 for ; Mon, 29 Nov 2021 20:36:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A00CB6157A; Mon, 29 Nov 2021 16:07:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF1FCC53FC7; Mon, 29 Nov 2021 16:07:56 +0000 (UTC) Date: Mon, 29 Nov 2021 11:07:55 -0500 From: Steven Rostedt To: Yafang Shao Cc: Sven Schnelle , David Hildenbrand , Andrew Morton , netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN Message-ID: <20211129110755.616133df@gandalf.local.home> In-Reply-To: References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <54e1b56c-e424-a4b3-4d61-3018aa095f36@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 655F630000BA Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of "SRS0=aZZo=QQ=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=aZZo=QQ=goodmis.org=rostedt@kernel.org" X-Stat-Signature: 8yuie9t5dma1iitksf6s5fr1ushbgmow X-HE-Tag: 1638218196-80513 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 29 Nov 2021 23:33:33 +0800 Yafang Shao wrote: > > TBH, i would vote for reverting the change. defining an array size as > > enum feels really odd. > > > > We changed it to enum because the BTF can't parse macro while it can > parse the enum type. I wonder if BTF could take advantage of the tracing: TRACE_DEFINE_ENUM() macros? This is how they are converted for user space tooling. Anyway, I'd have to go and look at why that trigger test failed. I don't see how the size of the array caused it to change the signage of value. -- Steve > Anyway I don't insist on keeping this change if you think reverting it > is better.