From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0376AC433F5 for ; Sun, 28 Nov 2021 00:07:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D8DA6B0075; Sat, 27 Nov 2021 19:07:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 586A26B0078; Sat, 27 Nov 2021 19:07:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44EF16B007B; Sat, 27 Nov 2021 19:07:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 3379B6B0075 for ; Sat, 27 Nov 2021 19:07:34 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E457B8BEC9 for ; Sun, 28 Nov 2021 00:07:23 +0000 (UTC) X-FDA: 78856399566.20.16FB387 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 4C4F5B000181 for ; Sun, 28 Nov 2021 00:07:19 +0000 (UTC) Received: from mail.kernel.org (unknown [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 255DDB80916; Sun, 28 Nov 2021 00:07:22 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5952F60524; Sun, 28 Nov 2021 00:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1638058040; bh=qezTYQseI9DxNpOdmT5kuzbuG73JbvoENi5WMIb3UJY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wqJban2R9O7yF/wfcwEI4K4ewdbM6sKnUWWUVW47r212gOjNx18PFLesOFaVBDsq3 23UqWBAtQRubS7Ips1ydm9qOT7CzelMqDvbO+0iE5DvCC4nrU8DDJJHNZx4pfYqvT5 G90iNCll6YneKYh+AF64jnxHQVZ12GpU+v+KUAqM= Date: Sat, 27 Nov 2021 16:07:18 -0800 From: Andrew Morton To: Calvin Zhang Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , Rob Herring , Frank Rowand , Catalin Marinas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH] mm: kmemleak: Ignore kmemleak scanning on CMA regions Message-Id: <20211127160718.54e82aa93c977a367404a9e3@linux-foundation.org> In-Reply-To: <20211126024711.54937-1-calvinzhang.cool@gmail.com> References: <20211126024711.54937-1-calvinzhang.cool@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4C4F5B000181 X-Stat-Signature: ke1qj4euhi4nwwyyxq9xnh387ds3ycq7 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wqJban2R; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1638058039-680840 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 26 Nov 2021 10:47:11 +0800 Calvin Zhang wrote: > Just like this: > commit 620951e27457 ("mm/cma: make kmemleak ignore CMA regions"). > > Add kmemleak_ignore_phys() for CMA created from of reserved node. Could we please have a full, standalone changelog for this patch? The 620951e27457 changelog says "Without this, the kernel crashes...". Does your patch also fix a crash? If so under what circumstances and should we backport this fix into -stable kernels? Etcetera.