From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0477AC433F5 for ; Fri, 26 Nov 2021 01:35:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4E416B0072; Thu, 25 Nov 2021 20:35:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD4BE6B0078; Thu, 25 Nov 2021 20:35:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A76106B007B; Thu, 25 Nov 2021 20:35:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 92D706B0072 for ; Thu, 25 Nov 2021 20:35:15 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 470BD8CE1D for ; Fri, 26 Nov 2021 01:35:05 +0000 (UTC) X-FDA: 78849362970.26.3ABDBA9 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf14.hostedemail.com (Postfix) with ESMTP id 447E260019B6 for ; Fri, 26 Nov 2021 01:35:03 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10179"; a="321823562" X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="321823562" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2021 17:35:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="475760400" Received: from lkp-server02.sh.intel.com (HELO 9e1e9f9b3bcb) ([10.239.97.151]) by orsmga002.jf.intel.com with ESMTP; 25 Nov 2021 17:35:00 -0800 Received: from kbuild by 9e1e9f9b3bcb with local (Exim 4.92) (envelope-from ) id 1mqQ8h-0007EQ-H6; Fri, 26 Nov 2021 01:34:59 +0000 Date: Fri, 26 Nov 2021 09:34:28 +0800 From: kernel test robot To: Alex Williamson Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Joerg Roedel , Lu Baolu Subject: [linux-next:master 2984/3632] drivers/iommu/intel/iommu.c:1344:7: warning: variable 'level_pfn' is used uninitialized whenever 'if' condition is true Message-ID: <202111260939.DmjPLz34-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 447E260019B6 Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf14.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=lkp@intel.com X-Stat-Signature: o17d5r9f9nfwx5kkg4o9dqjcs4ymfh4i X-HE-Tag: 1637890503-707571 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f81e94e91878bded599cc60f2881cfd50991aeb9 commit: edad96db58d2f0b666ddd0a3e0f179e586f5f66a [2984/3632] iommu/vt-d: Fix unmap_pages support config: x86_64-buildonly-randconfig-r004-20211126 (https://download.01.org/0day-ci/archive/20211126/202111260939.DmjPLz34-lkp@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 0332d105b9ad7f1f0ffca7e78b71de8b3a48f158) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=edad96db58d2f0b666ddd0a3e0f179e586f5f66a git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout edad96db58d2f0b666ddd0a3e0f179e586f5f66a # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/iommu/intel/iommu.c:1344:7: warning: variable 'level_pfn' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!dma_pte_present(pte)) ^~~~~~~~~~~~~~~~~~~~~ drivers/iommu/intel/iommu.c:1369:9: note: uninitialized use occurs here pfn = level_pfn + level_size(level); ^~~~~~~~~ drivers/iommu/intel/iommu.c:1344:3: note: remove the 'if' if its condition is always false if (!dma_pte_present(pte)) ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iommu/intel/iommu.c:1342:26: note: initialize the variable 'level_pfn' to silence this warning unsigned long level_pfn; ^ = 0 drivers/iommu/intel/iommu.c:136:29: warning: unused function 'dma_to_mm_pfn' [-Wunused-function] static inline unsigned long dma_to_mm_pfn(unsigned long dma_pfn) ^ 2 warnings generated. vim +1344 drivers/iommu/intel/iommu.c ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1329 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1330 static struct page *dma_pte_clear_level(struct dmar_domain *domain, int level, ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1331 struct dma_pte *pte, unsigned long pfn, ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1332 unsigned long start_pfn, ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1333 unsigned long last_pfn, ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1334 struct page *freelist) ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1335 { ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1336 struct dma_pte *first_pte = NULL, *last_pte = NULL; ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1337 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1338 pfn = max(start_pfn, pfn); ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1339 pte = &pte[pfn_level_offset(pfn, level)]; ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1340 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1341 do { ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1342 unsigned long level_pfn; ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1343 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 @1344 if (!dma_pte_present(pte)) ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1345 goto next; ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1346 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1347 level_pfn = pfn & level_mask(level); ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1348 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1349 /* If range covers entire pagetable, free it */ ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1350 if (start_pfn <= level_pfn && ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1351 last_pfn >= level_pfn + level_size(level) - 1) { ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1352 /* These suborbinate page tables are going away entirely. Don't ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1353 bother to clear them; we're just going to *free* them. */ ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1354 if (level > 1 && !dma_pte_superpage(pte)) ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1355 freelist = dma_pte_list_pagetables(domain, level - 1, pte, freelist); ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1356 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1357 dma_clear_pte(pte); ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1358 if (!first_pte) ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1359 first_pte = pte; ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1360 last_pte = pte; ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1361 } else if (level > 1) { ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1362 /* Recurse down into a level that isn't *entirely* obsolete */ ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1363 freelist = dma_pte_clear_level(domain, level - 1, ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1364 phys_to_virt(dma_pte_addr(pte)), ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1365 level_pfn, start_pfn, last_pfn, ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1366 freelist); ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1367 } ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1368 next: edad96db58d2f0b drivers/iommu/intel/iommu.c Alex Williamson 2021-11-22 1369 pfn = level_pfn + level_size(level); ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1370 } while (!first_pte_in_page(++pte) && pfn <= last_pfn); ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1371 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1372 if (first_pte) ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1373 domain_flush_cache(domain, first_pte, ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1374 (void *)++last_pte - (void *)first_pte); ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1375 ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1376 return freelist; ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1377 } ea8ea460c9ace60 drivers/iommu/intel-iommu.c David Woodhouse 2014-03-05 1378 :::::: The code at line 1344 was first introduced by commit :::::: ea8ea460c9ace60bbb5ac6e5521d637d5c15293d iommu/vt-d: Clean up and fix page table clear/free behaviour :::::: TO: David Woodhouse :::::: CC: David Woodhouse --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org