From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B74CC433F5 for ; Wed, 24 Nov 2021 20:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F9FF6B0078; Wed, 24 Nov 2021 15:12:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A77F6B007B; Wed, 24 Nov 2021 15:12:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1492A6B007D; Wed, 24 Nov 2021 15:12:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 05A6C6B0078 for ; Wed, 24 Nov 2021 15:12:52 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C030489065 for ; Wed, 24 Nov 2021 20:12:41 +0000 (UTC) X-FDA: 78844921722.25.1DCAE74 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf22.hostedemail.com (Postfix) with ESMTP id A7315190F for ; Wed, 24 Nov 2021 20:12:40 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id d11so7836448ljg.8 for ; Wed, 24 Nov 2021 12:12:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7soODcy9g9USyAcnsCV+bLWbMatBSsTCHZqUXUXsSj4=; b=Yms4+zGyu39UCWV++S7CaSRQGeVCEmSMEz3gocFHBCOuDmBYty1vgMvqYewwqeLCZD ZHm7NWjxJdoJbRuweJb9vapELXAsEGKkoWn1aDgKBAJeGd2m78XKk0S/SM3kBunfcD1m VtKJpqOzOBLaIdndK9yi/b3IJuNSIWngX/Sy3hMrAf45dXw2U3t5jVMOL2DWILFp35z5 7ylFYlqWT4QPlJPjfwBcHkMA05BXDtRzaBXL2dGolvos7e6IS9ElM5A2tdISbioMLqZ2 S5ZcC/YKBthw2T3/qGwtjNIorvEXWqbSPNOvluDKt34zOzfdJnSfsEoCr0KaXYruj3x0 UoIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7soODcy9g9USyAcnsCV+bLWbMatBSsTCHZqUXUXsSj4=; b=EFM6e9siAX0pt4vK0wVMhqdP/OvdpsDcJZvRkMEC5qlIOqSh7BmuABzIbP7VvQ7m4b RMQVkjRcKgekLBJ91QWD4G0XRiNp8TwniQ7NM2XzP0Wzpa7UvgOjx0n4zzyobmYv/0cI SakzMQcji7ImcPXIAl2UG8NVGKzyb9Aq1ngXMhdL+XwmXLOsHjpOB5c/fzrS9Ap6yLdI u6xY/BXdMACgabnOHQ4CIzpgRHh+/pMsHmL5mqEGLNWo3Wf9kEL4SfSJgAvO7eIZOKs3 LGGZ89fmBYIRHBhMCc/cGqeorb+wkRas38ylZr+ulMtF/sNID/5fm983XvZT3AYOtjC/ /kKA== X-Gm-Message-State: AOAM533LcunDwEyYrjtSvafjKWCRMYRCrRmDPb+Lh2N9oRCL1i4M//sN MNloO0ufT8pUEwWRyDf19X8qGQ== X-Google-Smtp-Source: ABdhPJzgCSYUjymEFFnyubOSAooaM8Jh3QpVKGVONm86IcfnDTxWfeicEF/z4JhlZpaT4d0FbGn+qg== X-Received: by 2002:a2e:97c7:: with SMTP id m7mr19495389ljj.134.1637784759805; Wed, 24 Nov 2021 12:12:39 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id y11sm87202ljh.54.2021.11.24.12.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 12:12:39 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id D0083103635; Wed, 24 Nov 2021 23:12:38 +0300 (+03) Date: Wed, 24 Nov 2021 23:12:38 +0300 From: "Kirill A. Shutemov" To: Shakeel Butt Cc: David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , Zi Yan , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: thp: update split_queue_len correctly Message-ID: <20211124201238.3xzpy2b5zcv7j23s@box.shutemov.name> References: <20211123190916.1738458-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211123190916.1738458-1-shakeelb@google.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A7315190F X-Stat-Signature: k3hzzt69axt8xajtrrh5qijbzt1rhykm Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=Yms4+zGy; dmarc=none; spf=none (imf22.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.175) smtp.mailfrom=kirill@shutemov.name X-HE-Tag: 1637784760-276858 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 23, 2021 at 11:09:16AM -0800, Shakeel Butt wrote: > The deferred THPs are split on memory pressure through shrinker > callback and splitting of THP during reclaim can fail for several > reasons like unable to lock the THP, under writeback or unexpected > number of pins on the THP. Such pages are put back on the deferred split > list for consideration later. However kernel does not update the > deferred queue size on putting back the pages whose split was failed. > This patch fixes that. Hm. No. split_huge_page_to_list() updates the queue size on split success. NAK. -- Kirill A. Shutemov