From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3071C433F5 for ; Wed, 24 Nov 2021 17:53:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25C006B0075; Wed, 24 Nov 2021 12:53:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20B7A6B0078; Wed, 24 Nov 2021 12:53:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ACE26B007B; Wed, 24 Nov 2021 12:53:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id F0F756B0075 for ; Wed, 24 Nov 2021 12:53:20 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A861F18194D63 for ; Wed, 24 Nov 2021 17:53:10 +0000 (UTC) X-FDA: 78844570224.10.2FA50B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id F267A508BB85 for ; Wed, 24 Nov 2021 17:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637776389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mASyT0OMl03qWDFFy00mhqeWIkZHCHpjVkFxkJ6erhk=; b=gqtDLTFmO0qgymnX+dm+kwESu4jensgURt4UVaSaw6rNLuzM/MGEnbMaWizNFWTrMMXJ/Y Hud6oaQwHEqv3Q2iol9JDYalR4ly5CoFzjH/EBlOEi5pklRNeLV1+/qJI68EudEOEtBR85 g/u1NQdFXLXYrVsUklT4G6pcjzYWE5o= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-99cG8WTlN7izkrngEl9Gcg-1; Wed, 24 Nov 2021 12:53:08 -0500 X-MC-Unique: 99cG8WTlN7izkrngEl9Gcg-1 Received: by mail-ot1-f69.google.com with SMTP id h15-20020a9d554f000000b0055c93007430so2067075oti.2 for ; Wed, 24 Nov 2021 09:53:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mASyT0OMl03qWDFFy00mhqeWIkZHCHpjVkFxkJ6erhk=; b=kUDtkO1o/R9Jifj359xnsYw9gqkOT+Ow5WKUT64KP6lx7P4h9EaSsa8TybuWeJJ22I ifnO5zwifVIjhHjG+MJQ5/gHXopI8KON30N+RwM4iytd8DyIYjVp78ZGAGS3BQD6Blpy 4HyYTVJ5m0PxqJSwVF/CtiP5kJDPGPIN/2HSoDc8CRM1B8JuPOAGx8s0Kish5k5BnEE1 eCyK9LBB2ADGAMaHA/Urliw20qnI3eWhArTdBBbjghbH4AJLoRjlwK01HNVdfiNJQzpJ uouFmbXMo/YULXDawjEa3BfWMyFL4eUhq4zeZCpFRXTdDlAR8cwNOUqRMgiBzhqVRASe UQIg== X-Gm-Message-State: AOAM53273Y3NrH8bwqABDo0dnrVF7LJaIfkMiHRB7+RMZwq+1leGj0Bj RaaNmEb7ziBUuR9vkfOSZsJ1VdCZO3JPUMg8EGsnv1eQmsXBQyvoBResoCYEd0mAg2F57lRB4BJ MZ0roBjGWf5k= X-Received: by 2002:a54:4f1d:: with SMTP id e29mr8178872oiy.179.1637776387886; Wed, 24 Nov 2021 09:53:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRWB6L5DthV9JqtypnlgpgoikvWzzaSh5YU1GEzYTaFfOEcTtDdkodALrrMwzR5kHOWImEJg== X-Received: by 2002:a54:4f1d:: with SMTP id e29mr8178778oiy.179.1637776387316; Wed, 24 Nov 2021 09:53:07 -0800 (PST) Received: from treble ([2600:1700:6e32:6c00::15]) by smtp.gmail.com with ESMTPSA id bj8sm123395oib.51.2021.11.24.09.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 09:53:06 -0800 (PST) Date: Wed, 24 Nov 2021 09:53:03 -0800 From: Josh Poimboeuf To: Marco Elver Cc: "Paul E. McKenney" , Alexander Potapenko , Boqun Feng , Borislav Petkov , Dmitry Vyukov , Ingo Molnar , Mark Rutland , Peter Zijlstra , Thomas Gleixner , Waiman Long , Will Deacon , kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v2 23/23] objtool, kcsan: Remove memory barrier instrumentation from noinstr Message-ID: <20211124175303.nwuk2zlnwkr7fj5f@treble> References: <20211118081027.3175699-1-elver@google.com> <20211118081027.3175699-24-elver@google.com> <20211119203135.clplwzh3hyo5xddg@treble> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: F267A508BB85 X-Stat-Signature: n3u4fwbk76pzs3jyhdt7otfoi7txf4nb Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gqtDLTFm; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of jpoimboe@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=jpoimboe@redhat.com X-Rspamd-Server: rspam02 X-HE-Tag: 1637776383-49804 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 23, 2021 at 12:29:39PM +0100, Marco Elver wrote: > On Fri, Nov 19, 2021 at 12:31PM -0800, Josh Poimboeuf wrote: > > On Thu, Nov 18, 2021 at 09:10:27AM +0100, Marco Elver wrote: > [...] > > > + if (insn->sec->noinstr && sym->removable_instr) { > [...] > > I'd love to have a clearer name than 'removable_instr', though I'm > > having trouble coming up with something. > [...] > > I now have the below as v3 of this patch. The naming isn't entirely > obvious, but coming up with a short name for this is tricky, but > hopefully the comments make it clear. We can of course still pick > another name. > > Does that look reasonable? > > Note, I'd like this series to sit in -next for a while (probably from > some time next week after sending v3 if there are no further > complaints). By default everything will be picked up by the -rcu tree, > and we're targeting Linux 5.18. > > If you feel there might be objtool conflicts coming, this patch could be > taken through another tree as there are no hard dependencies, as long as > this patch reaches mainline before or with the rest. > > Thanks, > -- Marco Looks good to me. I don't know of any upcoming conflicts, feel free to carry it with your series for now. Acked-by: Josh Poimboeuf -- Josh