* Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
2021-11-20 3:52 [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency Jakub Kicinski
@ 2021-11-20 4:47 ` Krzysztof Wilczyński
2021-11-20 7:30 ` Peter Chen
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Wilczyński @ 2021-11-20 4:47 UTC (permalink / raw)
To: Jakub Kicinski
Cc: bpf, axboe, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, yuq825,
robdclark, sean, christian.koenig, ray.huang, sgoutham, gakula,
sbhatta, hkelam, jingoohan1, lorenzo.pieralisi, robh, bhelgaas,
krzysztof.kozlowski, mani, pawell, peter.chen, rogerq,
a-govindraju, gregkh, ast, daniel, andrii, kafai, songliubraving,
yhs, john.fastabend, kpsingh, sj, akpm, thomas.hellstrom,
matthew.auld, colin.king, geert, linux-block, dri-devel,
intel-gfx, lima, linux-arm-msm, freedreno, linux-pci,
linux-arm-kernel, linux-samsung-soc, linux-usb, linux-mm
Hi Jakub,
[...]
> drivers/pci/controller/dwc/pci-exynos.c | 1 +
> drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 +
Happy to give
Acked-by: Krzysztof Wilczyński <kw@linux.com>
for the the PCI drivers. Thank you!
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
2021-11-20 3:52 [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency Jakub Kicinski
2021-11-20 4:47 ` Krzysztof Wilczyński
@ 2021-11-20 7:30 ` Peter Chen
2021-11-20 15:26 ` Jakub Kicinski
2021-11-20 7:39 ` SeongJae Park
2021-11-22 9:29 ` Jani Nikula
3 siblings, 1 reply; 7+ messages in thread
From: Peter Chen @ 2021-11-20 7:30 UTC (permalink / raw)
To: Jakub Kicinski
Cc: bpf, axboe, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, yuq825,
robdclark, sean, christian.koenig, ray.huang, sgoutham, gakula,
sbhatta, hkelam, jingoohan1, lorenzo.pieralisi, robh, kw,
bhelgaas, krzysztof.kozlowski, mani, pawell, rogerq,
a-govindraju, gregkh, ast, daniel, andrii, kafai, songliubraving,
yhs, john.fastabend, kpsingh, sj, akpm, thomas.hellstrom,
matthew.auld, colin.king, geert, linux-block, dri-devel,
intel-gfx, lima, linux-arm-msm, freedreno, linux-pci,
linux-arm-kernel, linux-samsung-soc, linux-usb, linux-mm
On 21-11-19 19:52:53, Jakub Kicinski wrote:
> cgroup.h (therefore swap.h, therefore half of the universe)
> includes bpf.h which in turn includes module.h and slab.h.
> Since we're about to get rid of that dependency we need
> to clean things up.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> static inline struct inode *bdev_file_inode(struct file *file)
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 7b9f69f21f1e..bca0de92802e 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -9,6 +9,7 @@
> #include <linux/shmem_fs.h>
> #include <linux/slab.h>
> #include <linux/vmalloc.h>
> +#include <linux/module.h>
>
> #ifdef CONFIG_X86
> #include <asm/set_memory.h>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c
> index 67d14afa6623..b67f620c3d93 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gtt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c
> @@ -6,6 +6,7 @@
> #include <linux/slab.h> /* fault-inject.h is not standalone! */
>
> #include <linux/fault-inject.h>
> +#include <linux/sched/mm.h>
>
> #include "gem/i915_gem_lmem.h"
> #include "i915_trace.h"
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 820a1f38b271..89cccefeea63 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -29,6 +29,7 @@
> #include <linux/sched.h>
> #include <linux/sched/clock.h>
> #include <linux/sched/signal.h>
> +#include <linux/sched/mm.h>
>
> #include "gem/i915_gem_context.h"
> #include "gt/intel_breadcrumbs.h"
> diff --git a/drivers/gpu/drm/lima/lima_device.c b/drivers/gpu/drm/lima/lima_device.c
> index 65fdca366e41..f74f8048af8f 100644
> --- a/drivers/gpu/drm/lima/lima_device.c
> +++ b/drivers/gpu/drm/lima/lima_device.c
> @@ -4,6 +4,7 @@
> #include <linux/regulator/consumer.h>
> #include <linux/reset.h>
> #include <linux/clk.h>
> +#include <linux/slab.h>
> #include <linux/dma-mapping.h>
> #include <linux/platform_device.h>
>
> diff --git a/drivers/gpu/drm/msm/msm_gem_shrinker.c b/drivers/gpu/drm/msm/msm_gem_shrinker.c
> index 4a1420b05e97..086dacf2f26a 100644
> --- a/drivers/gpu/drm/msm/msm_gem_shrinker.c
> +++ b/drivers/gpu/drm/msm/msm_gem_shrinker.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/vmalloc.h>
> +#include <linux/sched/mm.h>
>
> #include "msm_drv.h"
> #include "msm_gem.h"
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 7e83c00a3f48..79c870a3bef8 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -34,6 +34,7 @@
> #include <linux/sched.h>
> #include <linux/shmem_fs.h>
> #include <linux/file.h>
> +#include <linux/module.h>
> #include <drm/drm_cache.h>
> #include <drm/ttm/ttm_bo_driver.h>
>
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
> index a78c398bf5b2..01e7d3c0b68e 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
> @@ -8,6 +8,7 @@
> #include <linux/interrupt.h>
> #include <linux/etherdevice.h>
> #include <linux/netdevice.h>
> +#include <linux/module.h>
>
> #include "hinic_hw_dev.h"
> #include "hinic_dev.h"
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c
> index 0ef68fdd1f26..61c20907315f 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c
> @@ -5,6 +5,8 @@
> *
> */
>
> +#include <linux/module.h>
> +
> #include "otx2_common.h"
> #include "otx2_ptp.h"
>
> diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
> index c24dab383654..722dacdd5a17 100644
> --- a/drivers/pci/controller/dwc/pci-exynos.c
> +++ b/drivers/pci/controller/dwc/pci-exynos.c
> @@ -19,6 +19,7 @@
> #include <linux/platform_device.h>
> #include <linux/phy/phy.h>
> #include <linux/regulator/consumer.h>
> +#include <linux/module.h>
>
> #include "pcie-designware.h"
>
> diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> index 7b17da2f9b3f..cfe66bf04c1d 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> @@ -18,6 +18,7 @@
> #include <linux/pm_domain.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> +#include <linux/module.h>
>
> #include "pcie-designware.h"
>
> diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> index 84dadfa726aa..9643b905e2d8 100644
> --- a/drivers/usb/cdns3/host.c
> +++ b/drivers/usb/cdns3/host.c
> @@ -10,6 +10,7 @@
> */
>
> #include <linux/platform_device.h>
> +#include <linux/slab.h>
Should be "#include <linux/module.h>"?
--
Thanks,
Peter Chen
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
2021-11-20 7:30 ` Peter Chen
@ 2021-11-20 15:26 ` Jakub Kicinski
2021-11-23 12:51 ` Peter Chen
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Kicinski @ 2021-11-20 15:26 UTC (permalink / raw)
To: Peter Chen
Cc: bpf, axboe, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, yuq825,
robdclark, sean, christian.koenig, ray.huang, sgoutham, gakula,
sbhatta, hkelam, jingoohan1, lorenzo.pieralisi, robh, kw,
bhelgaas, krzysztof.kozlowski, mani, pawell, rogerq,
a-govindraju, gregkh, ast, daniel, andrii, kafai, songliubraving,
yhs, john.fastabend, kpsingh, sj, akpm, thomas.hellstrom,
matthew.auld, colin.king, geert, linux-block, dri-devel,
intel-gfx, lima, linux-arm-msm, freedreno, linux-pci,
linux-arm-kernel, linux-samsung-soc, linux-usb, linux-mm
On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
> > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> > index 84dadfa726aa..9643b905e2d8 100644
> > --- a/drivers/usb/cdns3/host.c
> > +++ b/drivers/usb/cdns3/host.c
> > @@ -10,6 +10,7 @@
> > */
> >
> > #include <linux/platform_device.h>
> > +#include <linux/slab.h>
>
> Should be "#include <linux/module.h>"?
Why? Different files are missing different includes, this one needs
slab.h:
../drivers/usb/cdns3/host.c: In function ‘__cdns_host_init’:
../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
kfree(cdns->xhci_plat_data);
^~~~~
vfree
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
2021-11-20 15:26 ` Jakub Kicinski
@ 2021-11-23 12:51 ` Peter Chen
0 siblings, 0 replies; 7+ messages in thread
From: Peter Chen @ 2021-11-23 12:51 UTC (permalink / raw)
To: Jakub Kicinski
Cc: bpf, axboe, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, yuq825,
robdclark, sean, christian.koenig, ray.huang, sgoutham, gakula,
sbhatta, hkelam, jingoohan1, lorenzo.pieralisi, robh, kw,
bhelgaas, krzysztof.kozlowski, mani, pawell, rogerq,
a-govindraju, gregkh, ast, daniel, andrii, kafai, songliubraving,
yhs, john.fastabend, kpsingh, sj, akpm, thomas.hellstrom,
matthew.auld, colin.king, geert, linux-block, dri-devel,
intel-gfx, lima, linux-arm-msm, freedreno, linux-pci,
linux-arm-kernel, linux-samsung-soc, linux-usb, linux-mm
On 21-11-20 07:26:02, Jakub Kicinski wrote:
> On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
> > > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> > > index 84dadfa726aa..9643b905e2d8 100644
> > > --- a/drivers/usb/cdns3/host.c
> > > +++ b/drivers/usb/cdns3/host.c
> > > @@ -10,6 +10,7 @@
> > > */
> > >
> > > #include <linux/platform_device.h>
> > > +#include <linux/slab.h>
> >
> > Should be "#include <linux/module.h>"?
>
> Why? Different files are missing different includes, this one needs
> slab.h:
>
> ../drivers/usb/cdns3/host.c: In function ‘__cdns_host_init’:
> ../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> kfree(cdns->xhci_plat_data);
> ^~~~~
> vfree
Oh, my fault.
Acked-by: Peter Chen <peter.chen@kernel.org>
--
Thanks,
Peter Chen
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
2021-11-20 3:52 [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency Jakub Kicinski
2021-11-20 4:47 ` Krzysztof Wilczyński
2021-11-20 7:30 ` Peter Chen
@ 2021-11-20 7:39 ` SeongJae Park
2021-11-22 9:29 ` Jani Nikula
3 siblings, 0 replies; 7+ messages in thread
From: SeongJae Park @ 2021-11-20 7:39 UTC (permalink / raw)
To: Jakub Kicinski
Cc: bpf, axboe, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, jani.nikula, joonas.lahtinen, rodrigo.vivi, yuq825,
robdclark, sean, christian.koenig, ray.huang, sgoutham, gakula,
sbhatta, hkelam, jingoohan1, lorenzo.pieralisi, robh, kw,
bhelgaas, krzysztof.kozlowski, mani, pawell, peter.chen, rogerq,
a-govindraju, gregkh, ast, daniel, andrii, kafai, songliubraving,
yhs, john.fastabend, kpsingh, sj, akpm, thomas.hellstrom,
matthew.auld, colin.king, geert, linux-block, dri-devel,
intel-gfx, lima, linux-arm-msm, freedreno, linux-pci,
linux-arm-kernel, linux-samsung-soc, linux-usb, linux-mm
Hi Jakub,
On Fri, 19 Nov 2021 19:52:53 -0800 Jakub Kicinski <kuba@kernel.org> wrote:
> cgroup.h (therefore swap.h, therefore half of the universe)
> includes bpf.h which in turn includes module.h and slab.h.
> Since we're about to get rid of that dependency we need
> to clean things up.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: SeongJae Park <sj@kernel.org>
for DAMON part.
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
2021-11-20 3:52 [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency Jakub Kicinski
` (2 preceding siblings ...)
2021-11-20 7:39 ` SeongJae Park
@ 2021-11-22 9:29 ` Jani Nikula
3 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2021-11-22 9:29 UTC (permalink / raw)
To: Jakub Kicinski, bpf
Cc: Jakub Kicinski, axboe, maarten.lankhorst, mripard, tzimmermann,
airlied, daniel, joonas.lahtinen, rodrigo.vivi, yuq825,
robdclark, sean, christian.koenig, ray.huang, sgoutham, gakula,
sbhatta, hkelam, jingoohan1, lorenzo.pieralisi, robh, kw,
bhelgaas, krzysztof.kozlowski, mani, pawell, peter.chen, rogerq,
a-govindraju, gregkh, ast, daniel, andrii, kafai, songliubraving,
yhs, john.fastabend, kpsingh, sj, akpm, thomas.hellstrom,
matthew.auld, colin.king, geert, linux-block, dri-devel,
intel-gfx, lima, linux-arm-msm, freedreno, linux-pci,
linux-arm-kernel, linux-samsung-soc, linux-usb, linux-mm
On Fri, 19 Nov 2021, Jakub Kicinski <kuba@kernel.org> wrote:
> cgroup.h (therefore swap.h, therefore half of the universe)
> includes bpf.h which in turn includes module.h and slab.h.
> Since we're about to get rid of that dependency we need
> to clean things up.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: axboe@kernel.dk
> CC: maarten.lankhorst@linux.intel.com
> CC: mripard@kernel.org
> CC: tzimmermann@suse.de
> CC: airlied@linux.ie
> CC: daniel@ffwll.ch
> CC: jani.nikula@linux.intel.com
> CC: joonas.lahtinen@linux.intel.com
> CC: rodrigo.vivi@intel.com
> CC: yuq825@gmail.com
> CC: robdclark@gmail.com
> CC: sean@poorly.run
> CC: christian.koenig@amd.com
> CC: ray.huang@amd.com
> CC: sgoutham@marvell.com
> CC: gakula@marvell.com
> CC: sbhatta@marvell.com
> CC: hkelam@marvell.com
> CC: jingoohan1@gmail.com
> CC: lorenzo.pieralisi@arm.com
> CC: robh@kernel.org
> CC: kw@linux.com
> CC: bhelgaas@google.com
> CC: krzysztof.kozlowski@canonical.com
> CC: mani@kernel.org
> CC: pawell@cadence.com
> CC: peter.chen@kernel.org
> CC: rogerq@kernel.org
> CC: a-govindraju@ti.com
> CC: gregkh@linuxfoundation.org
> CC: ast@kernel.org
> CC: daniel@iogearbox.net
> CC: andrii@kernel.org
> CC: kafai@fb.com
> CC: songliubraving@fb.com
> CC: yhs@fb.com
> CC: john.fastabend@gmail.com
> CC: kpsingh@kernel.org
> CC: sj@kernel.org
> CC: akpm@linux-foundation.org
> CC: thomas.hellstrom@linux.intel.com
> CC: matthew.auld@intel.com
> CC: colin.king@intel.com
> CC: geert@linux-m68k.org
> CC: linux-block@vger.kernel.org
> CC: dri-devel@lists.freedesktop.org
> CC: intel-gfx@lists.freedesktop.org
> CC: lima@lists.freedesktop.org
> CC: linux-arm-msm@vger.kernel.org
> CC: freedreno@lists.freedesktop.org
> CC: linux-pci@vger.kernel.org
> CC: linux-arm-kernel@lists.infradead.org
> CC: linux-samsung-soc@vger.kernel.org
> CC: linux-usb@vger.kernel.org
> CC: bpf@vger.kernel.org
> CC: linux-mm@kvack.org
>
> Well, let's see if this makes it thru email servers...
> ---
> block/fops.c | 1 +
> drivers/gpu/drm/drm_gem_shmem_helper.c | 1 +
> drivers/gpu/drm/i915/gt/intel_gtt.c | 1 +
> drivers/gpu/drm/i915/i915_request.c | 1 +
For the i915 parts,
Acked-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread