From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A05EC433F5 for ; Sun, 21 Nov 2021 11:33:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 308826B0071; Sun, 21 Nov 2021 06:33:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2913F6B0072; Sun, 21 Nov 2021 06:33:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 159346B0073; Sun, 21 Nov 2021 06:33:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 076EF6B0071 for ; Sun, 21 Nov 2021 06:33:37 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AFB298CA28 for ; Sun, 21 Nov 2021 11:33:26 +0000 (UTC) X-FDA: 78832726770.27.8065B00 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf27.hostedemail.com (Postfix) with ESMTP id 162E070000B6 for ; Sun, 21 Nov 2021 11:33:24 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id ABB4060E54; Sun, 21 Nov 2021 11:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637494405; bh=KrGsgGWqIO6v3E/xqeEmfERGvuO3FfTILF7qve6WynI=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=dKDtF8VivmaNaHPETPTODghem0k7WHA2JK+YeXOdbWz/6NGdMnleGaOpu3jRnbIT0 VjlYuW5e51SbnJutzFTbKcRVOt/1rmjL/gQteoZ6kozv1OhUfb5hkvQxSsKcF7g5K6 wMlgb0vXR7g8L9ca856lIAcEFmLXBALEux7FIcUuca4Db/8VTNWiiBfPhHdNcnXN2h 9xrVsi2dZy8mIVQhLrBu663Xd29RdciexGjamr1CkBcf9qqGE3zHnofYpVQgKm2fQi FojbzsZKQC2jq7+QPmXKroYTupxy34rrgOTXIaaoISxo9Fip7Xi5x95WvQcJsG+eHa PMvUvsMj56aBw== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1 2/2] mm/damon: move damon_rand definition into damon.h Date: Sun, 21 Nov 2021 11:33:12 +0000 Message-Id: <20211121113312.3942-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <6a4a7e53c2ab99028d431e7dc5e3d7635adb8522.1637429074.git.xhao@linux.alibaba.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 162E070000B6 X-Stat-Signature: wmxa6rcsq6pcbzudj58iem3qta7g9g44 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dKDtF8Vi; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1637494404-695360 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xin, On Sun, 21 Nov 2021 01:27:54 +0800 Xin Hao wrote: > damon_rand() is called in three files:damon/core.c, damon/ > paddr.c, damon/vaddr.c, i think there is no need to redefine > this twice, So move it to damon.h will be a good choice. Good finding. Could you please append '()' after 'damon_rand' in the title (s/damon_rand definition/damon_rand() definition)? > > Signed-off-by: Xin Hao After doing that, you could add Reviewed-by: SeongJae Park Thanks, SJ > --- > include/linux/damon.h | 4 ++++ > mm/damon/core.c | 4 ---- > mm/damon/prmtv-common.h | 4 ---- > 3 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index 8a73e825e0d5..8706b17a9acf 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -11,12 +11,16 @@ > #include > #include > #include > +#include > > /* Minimal region size. Every damon_region is aligned by this. */ > #define DAMON_MIN_REGION PAGE_SIZE > /* Max priority score for DAMON-based operation schemes */ > #define DAMOS_MAX_SCORE (99) > > +/* Get a random number in [l, r) */ > +#define damon_rand(l, r) (l + prandom_u32_max(r - l)) > + > /** > * struct damon_addr_range - Represents an address region of [@start, @end). > * @start: Start address of the region (inclusive). > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 4d2c3a0c7c8a..bdec32ef78c0 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -11,7 +11,6 @@ > #include > #include > #include > -#include > #include > #include > > @@ -23,9 +22,6 @@ > #define DAMON_MIN_REGION 1 > #endif > > -/* Get a random number in [l, r) */ > -#define damon_rand(l, r) (l + prandom_u32_max(r - l)) > - > static DEFINE_MUTEX(damon_lock); > static int nr_running_ctxs; > > diff --git a/mm/damon/prmtv-common.h b/mm/damon/prmtv-common.h > index 61f27037603e..e790cb5f8fe0 100644 > --- a/mm/damon/prmtv-common.h > +++ b/mm/damon/prmtv-common.h > @@ -6,10 +6,6 @@ > */ > > #include > -#include > - > -/* Get a random number in [l, r) */ > -#define damon_rand(l, r) (l + prandom_u32_max(r - l)) > > struct page *damon_get_page(unsigned long pfn); > > -- > 2.31.0 > >