From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CE9C433F5 for ; Sun, 21 Nov 2021 11:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFD626B0071; Sun, 21 Nov 2021 06:24:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C867A6B0072; Sun, 21 Nov 2021 06:24:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B26D36B0073; Sun, 21 Nov 2021 06:24:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 9ED956B0071 for ; Sun, 21 Nov 2021 06:24:43 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5ABCD8B75F for ; Sun, 21 Nov 2021 11:24:33 +0000 (UTC) X-FDA: 78832704426.06.A4B47ED Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP id 493C85092EF4 for ; Sun, 21 Nov 2021 11:24:29 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 928FB60E54; Sun, 21 Nov 2021 11:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637493872; bh=/u5GyBLZHocuj1Q9VEuGHkh2L3MrHSF+jdj5cFjvs9Y=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=PC1hhrZoAlUkoS8qh/j/B1kG2kZ0mrh1DJhSxiEb+tOpOb4dPCM65zF/nsyV4FDji gDU+hABIKFT8b2BI10XbJaPPhZeREg8ug7pJmRtPkzAeBxM96DR1UKn/Lic6sxCx0f MNtdxEOl1cHuDchgAGYLcILW0lTprGxTLy3tPuvjWfzM0UDcfJTfGT8mVOneaEb5Wj e9mgWKAO9ME0QY2HWJEOa46NEcJKfE+A6eH2x3VdVsOrFVzfyDTT1z0FFfuIKoLD83 LsWNjVG90QnR3dB9uXunsAkDLbccEr6rPLoN8S6HWO51JvYvJTB6cuuHnoCtIjQ47v njrT2LBeOlf1A== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V1 1/2] mm/damon/dbgfs: Modify Damon dbfs interface dependency in Kconfig Date: Sun, 21 Nov 2021 11:24:17 +0000 Message-Id: <20211121112417.33255-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-Rspamd-Queue-Id: 493C85092EF4 X-Stat-Signature: 3dwxz4op98mb379ysuqptd15q5rq1cw4 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PC1hhrZo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspamd-Server: rspam02 X-HE-Tag: 1637493869-586714 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xin, On Sun, 21 Nov 2021 01:27:53 +0800 Xin Hao wrote= : > If you want to support "DAMON_DBGFS" in config file, it only depends on > any one of "DAMON_VADDR" and "DAMON_PADDR". This is not true. DAMON_DBGFS really depends on both. This patch even makes the build fails with some configs. CC mm/damon/dbgfs.o linux/mm/damon/dbgfs.c: In function =E2=80=98dbgfs_target_ids_write=E2= =80=99: linux/mm/damon/dbgfs.c:409:3: error: implicit declaration of function= =E2=80=98damon_pa_set_primitives=E2=80=99; did you mean =E2=80=98damon_v= a_set_primitives=E2=80=99? [-Werror=3Dimplicit-function-declaration] damon_pa_set_primitives(ctx); ^~~~~~~~~~~~~~~~~~~~~~~ damon_va_set_primitives cc1: some warnings being treated as errors Thanks, SJ >=20 > Signed-off-by: Xin Hao > --- > mm/damon/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig > index 5bcf05851ad0..971ffc496596 100644 > --- a/mm/damon/Kconfig > +++ b/mm/damon/Kconfig > @@ -54,7 +54,7 @@ config DAMON_VADDR_KUNIT_TEST > =20 > config DAMON_DBGFS > bool "DAMON debugfs interface" > - depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS > + depends on DAMON_VADDR || DAMON_PADDR && DEBUG_FS > help > This builds the debugfs interface for DAMON. The user space admins > can use the interface for arbitrary data access monitoring. > --=20 > 2.31.0 >=20 >=20