From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8BBC433EF for ; Sat, 20 Nov 2021 15:26:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0FF26B0071; Sat, 20 Nov 2021 10:26:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C99066B0072; Sat, 20 Nov 2021 10:26:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B394D6B0073; Sat, 20 Nov 2021 10:26:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id A1E286B0071 for ; Sat, 20 Nov 2021 10:26:16 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6629D8770A for ; Sat, 20 Nov 2021 15:26:06 +0000 (UTC) X-FDA: 78829684332.23.265CBF8 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf11.hostedemail.com (Postfix) with ESMTP id ED71AF0000BF for ; Sat, 20 Nov 2021 15:26:05 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E5B5B60EB6; Sat, 20 Nov 2021 15:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637421964; bh=sL04+7/Tziaw15CHiE2bty/Bv6qeql7yB4oQSwHL8Rw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=N35/MX+Bk5IfQeZQiu16BeV4YuD31Ephij5WJvzDmZ2G+K+MjYa+HWqb1ahmMn5Hb 8nTHe95BsmdqkyFWylC9DLYJd5w68+maTSegSteQm994SJN2V2euBCo7o5awfS7MX1 1EqL1r1uDdGsdYVLkB0LepzAMd/DMg1DnO37cYnq/TOnx6T6gg4l1tr4VYZFrfdNBr fu07uKG0PLQcKTAn5J7IOkR76pmhpIN6NdZJHm5NPKAY2SAGobyGEmgVfnmJURZZPl Ncx/4o043Jc/OWEbZSwAM5dDl3KRkS71kl4wzNRFF/bIFRAmgFMC+aeEM6/O5rxXi9 UVuYgRSm1FojA== Date: Sat, 20 Nov 2021 07:26:02 -0800 From: Jakub Kicinski To: Peter Chen Cc: bpf@vger.kernel.org, axboe@kernel.dk, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, yuq825@gmail.com, robdclark@gmail.com, sean@poorly.run, christian.koenig@amd.com, ray.huang@amd.com, sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, jingoohan1@gmail.com, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, krzysztof.kozlowski@canonical.com, mani@kernel.org, pawell@cadence.com, rogerq@kernel.org, a-govindraju@ti.com, gregkh@linuxfoundation.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sj@kernel.org, akpm@linux-foundation.org, thomas.hellstrom@linux.intel.com, matthew.auld@intel.com, colin.king@intel.com, geert@linux-m68k.org, linux-block@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, lima@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency Message-ID: <20211120072602.22f9e722@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20211120073011.GA36650@Peter> References: <20211120035253.72074-1-kuba@kernel.org> <20211120073011.GA36650@Peter> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: ED71AF0000BF X-Stat-Signature: xzc3fm4356rwk85hqnw8csctqta9xdkg Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="N35/MX+B"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of kuba@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=kuba@kernel.org X-HE-Tag: 1637421965-739249 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote: > > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c > > index 84dadfa726aa..9643b905e2d8 100644 > > --- a/drivers/usb/cdns3/host.c > > +++ b/drivers/usb/cdns3/host.c > > @@ -10,6 +10,7 @@ > > */ > > =20 > > #include > > +#include =20 >=20 > Should be "#include "? Why? Different files are missing different includes, this one needs slab.h: ../drivers/usb/cdns3/host.c: In function =E2=80=98__cdns_host_init=E2=80=99: ../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function = =E2=80=98kfree=E2=80=99; did you mean =E2=80=98vfree=E2=80=99? [-Werror=3Di= mplicit-function-declaration] kfree(cdns->xhci_plat_data); ^~~~~ vfree