From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 482BCC433EF for ; Fri, 19 Nov 2021 16:55:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BFCCA610D0 for ; Fri, 19 Nov 2021 16:55:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BFCCA610D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3BC3E6B006C; Fri, 19 Nov 2021 11:55:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36B406B0071; Fri, 19 Nov 2021 11:55:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20BAB6B0073; Fri, 19 Nov 2021 11:55:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 0E9AF6B006C for ; Fri, 19 Nov 2021 11:55:44 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C39288B763 for ; Fri, 19 Nov 2021 16:55:33 +0000 (UTC) X-FDA: 78826280988.21.EEB8CE2 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf23.hostedemail.com (Postfix) with ESMTP id EF3C090000A6 for ; Fri, 19 Nov 2021 16:55:30 +0000 (UTC) Received: by mail-qk1-f179.google.com with SMTP id a11so10771859qkh.13 for ; Fri, 19 Nov 2021 08:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j4dfJtf70H4e5UXonwq16orQKWpXO+x06fxvhJKJ7d8=; b=d87IlRRZKxrvd7rCs0G5HYyKNpAqIXCVJoLZSm40EGxgBivy7DVYHW9jl8PdV3f0t9 uwh/0iLvXQfUE7gyV+yNM/B1VnvpEjlz94DfCQigJ+VVzR4T2y7neyZ1lkAmoNsCOWH6 oTZ5n6l+382na/fld2stLaq6r5mpXpViiMsdXA+yCjNagxbTD7ViK7JyltyY4cVIWVU2 T5fgYQWE0dQuWycS+LyQbQdaOsrC/7FUGemwET72O3Mn/EdKwGEX3ycQoJe0r801wXfw XgUuUYuo2ScFvmkD3BmxdnfomW4S3/fBTbfTxFKjmhk7E+ZAgCVCyg+IkHNk6QUPHgiv FYvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j4dfJtf70H4e5UXonwq16orQKWpXO+x06fxvhJKJ7d8=; b=6wfS8ivqzl2rqeEq1TDyvyzJuA81KurjOtSzfJhnBYt9WLB0tCxJCIsfv0htNAJmdQ ixy7SBWResHNxfMHO7f8UkbBvFxmJVxLjen4rBWYF4qGILKKxn2wJIUO8u0OfcSxAuF6 3T6NSQguwrO4Srcw7AbzTWjazKHKD7Zqoay+eyWTMGy10EGtFFxG847nhV+wX3MuWQyJ 6eodE8bzj7lyiEUYHNCK2B2xQkWNAW79zkAUYKVAsWtyIezNN5kVhcFxE/nKQGBqrJwP 3/Hr0BNv2pYRRgMStwoDgRRk9tI4JwR5stagMdrPrtVLm/KxxQ3CqzD6jADhzwbEPD0x +ajQ== X-Gm-Message-State: AOAM5312i6CK1f1ng2bivdbBF7ep3yBUZb8EetO5pX01S8dXxzBg9NQC JD4iTM+Zo2zLcE/fmB7XafZdwg== X-Google-Smtp-Source: ABdhPJxfzDa4XFzVN+Q5DxUZdjyMbl60WnM/StRJKUaZ2kCpuPhcN98F/USjrTo6H/4XkB1Jf6THKw== X-Received: by 2002:a05:620a:2805:: with SMTP id f5mr29033952qkp.151.1637340932761; Fri, 19 Nov 2021 08:55:32 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id k8sm123840qko.130.2021.11.19.08.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 08:55:31 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mo7Ag-00CLb6-N5; Fri, 19 Nov 2021 12:55:30 -0400 Date: Fri, 19 Nov 2021 12:55:30 -0400 From: Jason Gunthorpe To: Joao Martins Cc: Dan Williams , linux-mm@kvack.org, Vishal Verma , Dave Jiang , Naoya Horiguchi , Matthew Wilcox , John Hubbard , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Jonathan Corbet , Christoph Hellwig , nvdimm@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [PATCH v5 8/8] device-dax: compound devmap support Message-ID: <20211119165530.GJ876299@ziepe.ca> References: <20211112150824.11028-1-joao.m.martins@oracle.com> <20211112150824.11028-9-joao.m.martins@oracle.com> <20211112153404.GD876299@ziepe.ca> <01f36268-4010-ecea-fee5-c128dd8bb179@oracle.com> <20211115164909.GF876299@ziepe.ca> <4d74bfb8-2cff-237b-321b-05aff34c1e5d@oracle.com> <3b7f9516-a35a-e46e-83d4-3059a959d221@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b7f9516-a35a-e46e-83d4-3059a959d221@oracle.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EF3C090000A6 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=d87IlRRZ; dmarc=none; spf=pass (imf23.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.179 as permitted sender) smtp.mailfrom=jgg@ziepe.ca X-Stat-Signature: xwt95qzkkqyzhzx16ywqhe361x7nkme3 X-HE-Tag: 1637340930-220562 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 19, 2021 at 04:12:18PM +0000, Joao Martins wrote: > > Dan, any thoughts (see also below) ? You probably hold all that > > history since its inception on commit 2232c6382a4 ("device-dax: Enable page_mapping()") > > and commit 35de299547d1 ("device-dax: Set page->index"). > > > Below is what I have staged so far as a percursor patch (see below scissors mark). > > It also lets me simplify compound page case for __dax_set_mapping() in this patch, > like below diff. > > But I still wonder whether this ordering adjustment of @mapping setting is best placed > as a percursor patch whenever pgmap/page refcount changes happen. Anyways it's just a > thought. naively I would have thought you'd set the mapping on all pages when you create the address_space and allocate pages into it. AFAIK devmap assigns all pages to a single address_space, so shouldn't the mapping just be done once? Jason