Re: [PATCH v3 1/4] mm/shmem: support deterministic charging of tmpfs

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2161 bytes --]

Hi Mina,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on hnaz-mm/master]

url:    https://github.com/0day-ci/linux/commits/Mina-Almasry/mm-shmem-support-deterministic-charging-of-tmpfs/20211112-084506
base:   https://github.com/hnaz/linux-mm master
config: um-i386_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/51d8c281f9e96cc0269902e4597a972c7e2510f0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mina-Almasry/mm-shmem-support-deterministic-charging-of-tmpfs/20211112-084506
        git checkout 51d8c281f9e96cc0269902e4597a972c7e2510f0
        # save the attached .config to linux build tree
        make W=1 ARCH=um SUBARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/super.c: In function 'destroy_unused_super':
>> fs/super.c:184:5: warning: "CONFIG_MEMCG" is not defined, evaluates to 0 [-Wundef]
     184 | #if CONFIG_MEMCG
         |     ^~~~~~~~~~~~
   fs/super.c: In function '__put_super':
   fs/super.c:299:5: warning: "CONFIG_MEMCG" is not defined, evaluates to 0 [-Wundef]
     299 | #if CONFIG_MEMCG
         |     ^~~~~~~~~~~~


vim +/CONFIG_MEMCG +184 fs/super.c

   175	
   176	/* Free a superblock that has never been seen by anyone */
   177	static void destroy_unused_super(struct super_block *s)
   178	{
   179		if (!s)
   180			return;
   181		up_write(&s->s_umount);
   182		list_lru_destroy(&s->s_dentry_lru);
   183		list_lru_destroy(&s->s_inode_lru);
 > 184	#if CONFIG_MEMCG
   185		mem_cgroup_set_charge_target(&s->s_memcg_to_charge, NULL);
   186	#endif
   187		security_sb_free(s);
   188		put_user_ns(s->s_user_ns);
   189		kfree(s->s_subtype);
   190		free_prealloced_shrinker(&s->s_shrink);
   191		/* no delays needed */
   192		destroy_super_work(&s->destroy_work);
   193	}
   194	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 9939 bytes --]