From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F97C433F5 for ; Wed, 10 Nov 2021 18:06:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD0D0611C9 for ; Wed, 10 Nov 2021 18:06:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BD0D0611C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 329656B006C; Wed, 10 Nov 2021 13:06:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D8B06B0071; Wed, 10 Nov 2021 13:06:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C7126B0072; Wed, 10 Nov 2021 13:06:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 098C96B006C for ; Wed, 10 Nov 2021 13:06:15 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9814C7DC94 for ; Wed, 10 Nov 2021 18:06:13 +0000 (UTC) X-FDA: 78793799826.29.CE78FD1 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf31.hostedemail.com (Postfix) with ESMTP id AD1B0104B95A for ; Wed, 10 Nov 2021 18:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NjWp/DEt+8bVHPs1gmDRocuQVRMShr5c3n+CoKHRG3Y=; b=FgTPGGCfgvuH/hxPJ+BKPW63ZY 2h9xXsa8BCA8uE7nrHtXOFynwE/3wW600gdD7y23kFti+2gx0Or+nKJxcni9NEVgR0taz97mPYEwp +cNTH7BvpALxKGQpA4TsoBMFRlLoVyadyWiCwQ9vvSeW5hfnXKo50OoDN++CzUlZVDE3HjH23IcrL HK8VVB4CTu5vahV/VTUIQYs1Twx3h/kEYMVYls/xN4Zx0oWdCTc9we4AunzgYMPXeGO5uENnHDIX2 jFW+u6R9AOPytdq+Oe9GnVSUx7948uS3hWAUxAWg3zy+Xr6uhbsOX+NS1tGx15JkaiUxUTYH1Lj8q gdv9DCKQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkqEf-00FInD-11; Wed, 10 Nov 2021 16:14:05 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id B7BD0986972; Wed, 10 Nov 2021 17:14:02 +0100 (CET) Date: Wed, 10 Nov 2021 17:14:02 +0100 From: Peter Zijlstra To: Georgi Djakov Cc: hannes@cmpxchg.org, vincent.guittot@linaro.org, juri.lelli@redhat.com, mingo@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, mhocko@kernel.org, vdavydov.dev@gmail.com, tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, djakov@kernel.org Subject: Re: [RFC] psi: Add additional PSI counters for each type of memory pressure Message-ID: <20211110161402.GB174703@worktop.programming.kicks-ass.net> References: <1636558597-248294-1-git-send-email-quic_c_gdjako@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1636558597-248294-1-git-send-email-quic_c_gdjako@quicinc.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AD1B0104B95A X-Stat-Signature: rpy5qh8rbaogsku1my1ppbnhemjhg66w Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=FgTPGGCf; dmarc=none; spf=none (imf31.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org X-HE-Tag: 1636567559-530037 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 10, 2021 at 07:36:37AM -0800, Georgi Djakov wrote: > @@ -21,7 +19,18 @@ enum psi_task_count { > * don't have to special case any state tracking for it. > */ > NR_ONCPU, > - NR_PSI_TASK_COUNTS = 4, > + NR_BLK_CGROUP_THROTTLE, > + NR_BIO, > + NR_COMPACTION, > + NR_THRASHING, > + NR_CGROUP_RECLAIM_HIGH, > + NR_CGROUP_RECLAIM_HIGH_SLEEP, > + NR_CGROUP_TRY_CHARGE, > + NR_DIRECT_COMPACTION, > + NR_DIRECT_RECLAIM, > + NR_READ_SWAPPAGE, > + NR_KSWAPD, > + NR_PSI_TASK_COUNTS = 16, > }; > > @@ -51,9 +80,20 @@ enum psi_states { > PSI_MEM_FULL, > PSI_CPU_SOME, > PSI_CPU_FULL, > + PSI_BLK_CGROUP_THROTTLE, > + PSI_BIO, > + PSI_COMPACTION, > + PSI_THRASHING, > + PSI_CGROUP_RECLAIM_HIGH, > + PSI_CGROUP_RECLAIM_HIGH_SLEEP, > + PSI_CGROUP_TRY_CHARGE, > + PSI_DIRECT_COMPACTION, > + PSI_DIRECT_RECLAIM, > + PSI_READ_SWAPPAGE, > + PSI_KSWAPD, > /* Only per-CPU, to weigh the CPU in the global average: */ > PSI_NONIDLE, > - NR_PSI_STATES = 7, > + NR_PSI_STATES = 18, > }; Have you considered what this does to psi_group_cpu's size and layout and the impact thereof on performance?