From: Peter Zijlstra <peterz@infradead.org>
To: Georgi Djakov <quic_c_gdjako@quicinc.com>
Cc: hannes@cmpxchg.org, vincent.guittot@linaro.org,
juri.lelli@redhat.com, mingo@redhat.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
mhocko@kernel.org, vdavydov.dev@gmail.com, tj@kernel.org,
axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
djakov@kernel.org
Subject: Re: [RFC] psi: Add additional PSI counters for each type of memory pressure
Date: Wed, 10 Nov 2021 17:14:02 +0100 [thread overview]
Message-ID: <20211110161402.GB174703@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1636558597-248294-1-git-send-email-quic_c_gdjako@quicinc.com>
On Wed, Nov 10, 2021 at 07:36:37AM -0800, Georgi Djakov wrote:
> @@ -21,7 +19,18 @@ enum psi_task_count {
> * don't have to special case any state tracking for it.
> */
> NR_ONCPU,
> - NR_PSI_TASK_COUNTS = 4,
> + NR_BLK_CGROUP_THROTTLE,
> + NR_BIO,
> + NR_COMPACTION,
> + NR_THRASHING,
> + NR_CGROUP_RECLAIM_HIGH,
> + NR_CGROUP_RECLAIM_HIGH_SLEEP,
> + NR_CGROUP_TRY_CHARGE,
> + NR_DIRECT_COMPACTION,
> + NR_DIRECT_RECLAIM,
> + NR_READ_SWAPPAGE,
> + NR_KSWAPD,
> + NR_PSI_TASK_COUNTS = 16,
> };
>
> @@ -51,9 +80,20 @@ enum psi_states {
> PSI_MEM_FULL,
> PSI_CPU_SOME,
> PSI_CPU_FULL,
> + PSI_BLK_CGROUP_THROTTLE,
> + PSI_BIO,
> + PSI_COMPACTION,
> + PSI_THRASHING,
> + PSI_CGROUP_RECLAIM_HIGH,
> + PSI_CGROUP_RECLAIM_HIGH_SLEEP,
> + PSI_CGROUP_TRY_CHARGE,
> + PSI_DIRECT_COMPACTION,
> + PSI_DIRECT_RECLAIM,
> + PSI_READ_SWAPPAGE,
> + PSI_KSWAPD,
> /* Only per-CPU, to weigh the CPU in the global average: */
> PSI_NONIDLE,
> - NR_PSI_STATES = 7,
> + NR_PSI_STATES = 18,
> };
Have you considered what this does to psi_group_cpu's size and layout
and the impact thereof on performance?
next prev parent reply other threads:[~2021-11-10 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 15:36 Georgi Djakov
2021-11-10 16:07 ` Michal Hocko
2021-11-10 16:45 ` Georgi Djakov
2021-11-10 16:14 ` Peter Zijlstra [this message]
2021-11-10 16:45 ` Georgi Djakov
2021-11-10 17:48 ` Suren Baghdasaryan
2021-11-10 16:44 ` Johannes Weiner
2021-12-01 19:26 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110161402.GB174703@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=quic_c_gdjako@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox