* [PATCH] mm/damon/vaddr: use swap() to make code cleaner
@ 2021-11-10 3:32 Yihao Han
2021-11-10 4:15 ` Muchun Song
0 siblings, 1 reply; 3+ messages in thread
From: Yihao Han @ 2021-11-10 3:32 UTC (permalink / raw)
To: SeongJae Park, Andrew Morton, linux-mm, linux-kernel; +Cc: kernel, Yihao Han
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
mm/damon/vaddr.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
index 35fe49080ee9..414d9fb9c827 100644
--- a/mm/damon/vaddr.c
+++ b/mm/damon/vaddr.c
@@ -100,11 +100,7 @@ static unsigned long sz_range(struct damon_addr_range *r)
static void swap_ranges(struct damon_addr_range *r1,
struct damon_addr_range *r2)
{
- struct damon_addr_range tmp;
-
- tmp = *r1;
- *r1 = *r2;
- *r2 = tmp;
+ swap(*r1, *r2);
}
/*
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/damon/vaddr: use swap() to make code cleaner
2021-11-10 3:32 [PATCH] mm/damon/vaddr: use swap() to make code cleaner Yihao Han
@ 2021-11-10 4:15 ` Muchun Song
2021-11-10 7:44 ` SeongJae Park
0 siblings, 1 reply; 3+ messages in thread
From: Muchun Song @ 2021-11-10 4:15 UTC (permalink / raw)
To: Yihao Han
Cc: SeongJae Park, Andrew Morton, Linux Memory Management List, LKML, kernel
On Wed, Nov 10, 2021 at 11:32 AM Yihao Han <hanyihao@vivo.com> wrote:
>
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> mm/damon/vaddr.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index 35fe49080ee9..414d9fb9c827 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
> @@ -100,11 +100,7 @@ static unsigned long sz_range(struct damon_addr_range *r)
> static void swap_ranges(struct damon_addr_range *r1,
> struct damon_addr_range *r2)
> {
> - struct damon_addr_range tmp;
> -
> - tmp = *r1;
> - *r1 = *r2;
> - *r2 = tmp;
> + swap(*r1, *r2);
IMHO, I suggest removing swap_ranges() completely
since it's only a wrapper of swap() after your changes.
The caller can invoke swap() directly.
Thanks.
> }
>
> /*
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/damon/vaddr: use swap() to make code cleaner
2021-11-10 4:15 ` Muchun Song
@ 2021-11-10 7:44 ` SeongJae Park
0 siblings, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2021-11-10 7:44 UTC (permalink / raw)
To: Muchun Song
Cc: Yihao Han, SeongJae Park, Andrew Morton,
Linux Memory Management List, LKML, kernel
On Wed, 10 Nov 2021 12:15:57 +0800 Muchun Song <songmuchun@bytedance.com> wrote:
> On Wed, Nov 10, 2021 at 11:32 AM Yihao Han <hanyihao@vivo.com> wrote:
> >
> > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> > opencoding it.
> >
> > Signed-off-by: Yihao Han <hanyihao@vivo.com>
> > ---
> > mm/damon/vaddr.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> > index 35fe49080ee9..414d9fb9c827 100644
> > --- a/mm/damon/vaddr.c
> > +++ b/mm/damon/vaddr.c
> > @@ -100,11 +100,7 @@ static unsigned long sz_range(struct damon_addr_range *r)
> > static void swap_ranges(struct damon_addr_range *r1,
> > struct damon_addr_range *r2)
> > {
> > - struct damon_addr_range tmp;
> > -
> > - tmp = *r1;
> > - *r1 = *r2;
> > - *r2 = tmp;
> > + swap(*r1, *r2);
>
> IMHO, I suggest removing swap_ranges() completely
> since it's only a wrapper of swap() after your changes.
> The caller can invoke swap() directly.
I also agree to Muchun.
Thanks,
SJ
>
> Thanks.
>
> > }
> >
> > /*
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-10 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 3:32 [PATCH] mm/damon/vaddr: use swap() to make code cleaner Yihao Han
2021-11-10 4:15 ` Muchun Song
2021-11-10 7:44 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox