From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CF4C4332F for ; Tue, 9 Nov 2021 18:28:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2329561166 for ; Tue, 9 Nov 2021 18:28:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2329561166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 78D316B0095; Tue, 9 Nov 2021 13:28:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73CE76B0099; Tue, 9 Nov 2021 13:28:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 604906B009B; Tue, 9 Nov 2021 13:28:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id 4DF246B0095 for ; Tue, 9 Nov 2021 13:28:22 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 03BCA7DCA7 for ; Tue, 9 Nov 2021 18:28:22 +0000 (UTC) X-FDA: 78790226844.11.BD32ABE Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf06.hostedemail.com (Postfix) with ESMTP id 94783801AF3F for ; Tue, 9 Nov 2021 18:28:21 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id v20so74145plo.7 for ; Tue, 09 Nov 2021 10:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YqtAkERQI/ln6XRRI9t4KGym2pBKGt4SPOY54xOyYmc=; b=PGOJkkhM/AspXaJubyodGGt3bokcuo1nWeF66Ozy2PSHqL4ozl1ealnJ2sESU77Daa 5PCgxSnMKmr5LSn7P+UZw5lKAiqvWF452/e/zcO5+QvHTusOJTtt+u60C6PqqZ1Yg/LF XnAN//7pVh4I0+4GH1pCdd6cp3HnHcZsIY7gg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YqtAkERQI/ln6XRRI9t4KGym2pBKGt4SPOY54xOyYmc=; b=5BP3+m2e8qSn+82LYA/WlQ0346wWmTxj5cIBNPYJt8Tkjpfe4cufvLWQJsGqGn1JCM mRVpr774gKz5lxUEwQ+SsEalDh1KEaxXhc95HnWPzJTrl+xgFE1odpZghED/G5ryls8d +X48KRlwrHKDuxCC8uasU0VMdARslu1cHtCZtDwtWFCB6GCY8dClC4LiG51abkvZcHCU AL9BRZ6SxjF9h6V6ER6NkiFWVn1TzM+ma+lVhMpUTVdMIMVKksexH8itt3Ho8MZMQaVW di7yVHMkRY4POkDuerW8mFNQNHRpVroNcteA++dr4ghJIRrZQBcm8PpIzSVLdAAhCuf2 Iyjg== X-Gm-Message-State: AOAM530rotGR/L44FtsGpVRz3CV+dM7TBjNNv+NtPW9wtO0C2/JxLTCn QnCtKer+HbhIyUTSd0s1+nCTcA== X-Google-Smtp-Source: ABdhPJw56zqbHPhzHi/UjO1EuTMs0ckASHUWtACCQVftB6fOpzf6idVKbxIvoc6DXqmWnHNuFyu1UQ== X-Received: by 2002:a17:90b:3a89:: with SMTP id om9mr9485773pjb.29.1636482500572; Tue, 09 Nov 2021 10:28:20 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u11sm7194577pfk.152.2021.11.09.10.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 10:28:20 -0800 (PST) Date: Tue, 9 Nov 2021 10:28:19 -0800 From: Kees Cook To: Yafang Shao Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Mathieu Desnoyers , Arnaldo Carvalho de Melo , Alexei Starovoitov , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , David Hildenbrand , Al Viro , Petr Mladek Subject: Re: [PATCH 0/7] task comm cleanups Message-ID: <202111091027.DEF1B6DD@keescook> References: <20211108083840.4627-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211108083840.4627-1-laoar.shao@gmail.com> Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PGOJkkhM; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 94783801AF3F X-Stat-Signature: 511u1azkuqw4ya6je746twm1fw9iy1cz X-HE-Tag: 1636482501-185201 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 08, 2021 at 08:38:33AM +0000, Yafang Shao wrote: > This patchset is part of the patchset "extend task comm from 16 to 24"[1]. > Now we have different opinion that dynamically allocates memory to store > kthread's long name into a separate pointer, so I decide to take the useful > cleanups apart from the original patchset and send it separately[2]. > > These useful cleanups can make the usage around task comm less > error-prone. Furthermore, it will be useful if we want to extend task > comm in the future. > > All of the patches except patch #4 have either a reviewed-by or a > acked-by now. I have verfied that the vmcore/crash works well after > patch #4. > > [1]. https://lore.kernel.org/lkml/20211101060419.4682-1-laoar.shao@gmail.com/ > [2]. https://lore.kernel.org/lkml/CALOAHbAx55AUo3bm8ZepZSZnw7A08cvKPdPyNTf=E_tPqmw5hw@mail.gmail.com/ Thanks for collecting this! It all looks good to me. Andrew, can you take these? -Kees -- Kees Cook