From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC6BC433EF for ; Fri, 5 Nov 2021 20:39:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 37DA0611C4 for ; Fri, 5 Nov 2021 20:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 37DA0611C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D12FC940061; Fri, 5 Nov 2021 16:39:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBE50940049; Fri, 5 Nov 2021 16:39:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B88BA940061; Fri, 5 Nov 2021 16:39:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id A6F09940049 for ; Fri, 5 Nov 2021 16:39:58 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6C7CF82499A8 for ; Fri, 5 Nov 2021 20:39:58 +0000 (UTC) X-FDA: 78776043276.37.A52093D Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP id 9ED95508FA48 for ; Fri, 5 Nov 2021 20:39:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E145611C0; Fri, 5 Nov 2021 20:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1636144797; bh=qp1GkC5rhtav/0WU3qrAq2fB/epoumgn+EcvJW6QSz0=; h=Date:From:To:Subject:In-Reply-To:From; b=YxnMr26d7GE2uJ2wBmpatyUv6NoqV5pUjsh9mNl6o1oqkfBVFtkV1TjwOeMRCD7/S Wq8d5fqoHOiJMoxWpUgFHNhexMMEYshNeT/7k9p7zBOHNo6o/6ubgqTgE0ooECUa5H s1Evxyd17d5Cvpyi+aZtWcpDJMWeHEbyYi6Fwh3Y= Date: Fri, 05 Nov 2021 13:39:56 -0700 From: Andrew Morton To: akpm@linux-foundation.org, deng.changcheng@zte.com.cn, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, urezki@gmail.com, zealci@zte.com.cn Subject: [patch 101/262] lib/test_vmalloc.c: use swap() to make code cleaner Message-ID: <20211105203956.bvvtKSnFq%akpm@linux-foundation.org> In-Reply-To: <20211105133408.cccbb98b71a77d5e8430aba1@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9ED95508FA48 X-Stat-Signature: 5pkdc9xm49mih7nhpbqfxs7tabs9c48g Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YxnMr26d; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1636144780-467860 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001732, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Changcheng Deng Subject: lib/test_vmalloc.c: use swap() to make code cleaner Use swap() in order to make code cleaner. Issue found by coccinelle. Link: https://lkml.kernel.org/r/20211028111443.15744-1-deng.changcheng@zte.com.cn Signed-off-by: Changcheng Deng Reported-by: Zeal Robot Reviewed-by: Uladzislau Rezki (Sony) Signed-off-by: Andrew Morton --- lib/test_vmalloc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/lib/test_vmalloc.c~lib-test_vmallocc-use-swap-to-make-code-cleaner +++ a/lib/test_vmalloc.c @@ -393,7 +393,7 @@ static struct test_driver { static void shuffle_array(int *arr, int n) { unsigned int rnd; - int i, j, x; + int i, j; for (i = n - 1; i > 0; i--) { get_random_bytes(&rnd, sizeof(rnd)); @@ -402,9 +402,7 @@ static void shuffle_array(int *arr, int j = rnd % i; /* Swap indexes. */ - x = arr[i]; - arr[i] = arr[j]; - arr[j] = x; + swap(arr[i], arr[j]); } } _