From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E7A6C433EF for ; Fri, 5 Nov 2021 20:37:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 08F92611EE for ; Fri, 5 Nov 2021 20:37:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08F92611EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9DF6594002A; Fri, 5 Nov 2021 16:37:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9690D940007; Fri, 5 Nov 2021 16:37:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E2C094002A; Fri, 5 Nov 2021 16:37:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 6DEFC940007 for ; Fri, 5 Nov 2021 16:37:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 38E30777F4 for ; Fri, 5 Nov 2021 20:37:03 +0000 (UTC) X-FDA: 78776036010.05.D757863 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id DFECFF0003A0 for ; Fri, 5 Nov 2021 20:37:02 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DCEA461242; Fri, 5 Nov 2021 20:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1636144622; bh=whFe3f09wOkOblZuiOhkmdNFJjqy8eyUdcc/AyCZSxo=; h=Date:From:To:Subject:In-Reply-To:From; b=W7KgDrzY4E4V56cknMYQW+oYGS+Ui83/U8ArReRajRz5R2dy3hKbp45LdXnEBPB6x aJe4ZZXZJWb2D3gAbRoHSZIQeM4oLT5fxF3O4voxnG1pz1QG9kSHYwa9LOZHk4zqex zdn5ssdCo4DQE8E2k7dZSUZuDpJRUz1ot6mzqg1E= Date: Fri, 05 Nov 2021 13:37:01 -0700 From: Andrew Morton To: akpm@linux-foundation.org, hch@lst.de, jack@suse.cz, linux-mm@kvack.org, miquel.raynal@bootlin.com, mm-commits@vger.kernel.org, richard@nod.at, torvalds@linux-foundation.org, vigneshr@ti.com Subject: [patch 045/262] mm: don't automatically unregister bdis Message-ID: <20211105203701.M3N9WiZBX%akpm@linux-foundation.org> In-Reply-To: <20211105133408.cccbb98b71a77d5e8430aba1@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DFECFF0003A0 X-Stat-Signature: bh8sjxgoirm3gnzb674813g66t8hezei Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=W7KgDrzY; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1636144622-975026 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Christoph Hellwig Subject: mm: don't automatically unregister bdis All BDI users now unregister explicitly. Link: https://lkml.kernel.org/r/20211021124441.668816-5-hch@lst.de Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Signed-off-by: Andrew Morton --- mm/backing-dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/mm/backing-dev.c~mm-dont-automatically-unregister-bdis +++ a/mm/backing-dev.c @@ -965,8 +965,7 @@ static void release_bdi(struct kref *ref struct backing_dev_info *bdi = container_of(ref, struct backing_dev_info, refcnt); - if (test_bit(WB_registered, &bdi->wb.state)) - bdi_unregister(bdi); + WARN_ON_ONCE(test_bit(WB_registered, &bdi->wb.state)); WARN_ON_ONCE(bdi->dev); wb_exit(&bdi->wb); kfree(bdi); _