From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Xu <peterx@redhat.com>
Cc: Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Liam Howlett <liam.howlett@oracle.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Yang Shi <shy828301@gmail.com>,
David Hildenbrand <david@redhat.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Jerome Glisse <jglisse@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Matthew Wilcox <willy@infradead.org>,
Axel Rasmussen <axelrasmussen@google.com>
Subject: Re: [PATCH v4 1/4] mm/shmem: Unconditionally set pte dirty in mfill_atomic_install_pte
Date: Thu, 4 Nov 2021 14:34:40 -0700 [thread overview]
Message-ID: <20211104143440.d0056137ee07d3e96d6b56ec@linux-foundation.org> (raw)
In-Reply-To: <YVOLG3NIlj+16IUh@t490s>
On Tue, 28 Sep 2021 17:37:31 -0400 Peter Xu <peterx@redhat.com> wrote:
> > How about a compromise (if you really want to continue with this patch):
> > you leave the SetPageDirty(page) in shmem_mfill_atomic_pte(), where I
> > feel a responsibility for it; but you do whatever works for you with
> > pte_mkdirty() at the mm/userfaultfd.c end?
>
> Sure. Duplicating dirty bit is definitely fine to me as it achieves the same
> goal as I hoped - we're still 100% clear we won't free a uffd page without
> being noticed, then that's enough to me for the goal of this patch. I won't
> initiate that NACK myself since I still think duplicating is unnecessary no
> matter it resides in shmem or uffd code, but please go ahead doing that and
> I'll be fine with it, just in case Andrew didn't follow the details.
I think Hugh was asking you to implement this...
I guess I'll send this patch upstream. But it does sound like Hugh
would prefer a followon patch for this kernel release which makes the
above change, please.
next prev parent reply other threads:[~2021-11-04 21:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 18:14 [PATCH v4 0/4] mm: A few cleanup patches around zap, shmem and uffd Peter Xu
2021-09-15 18:14 ` [PATCH v4 1/4] mm/shmem: Unconditionally set pte dirty in mfill_atomic_install_pte Peter Xu
2021-09-24 3:56 ` Hugh Dickins
2021-09-27 21:21 ` Peter Xu
2021-09-28 19:28 ` Hugh Dickins
2021-09-28 21:37 ` Peter Xu
2021-11-04 21:34 ` Andrew Morton [this message]
2021-11-05 1:01 ` Peter Xu
2021-09-15 18:15 ` [PATCH v4 2/4] mm: Clear vmf->pte after pte_unmap_same() returns Peter Xu
2021-09-24 3:59 ` Hugh Dickins
2021-09-15 18:15 ` [PATCH v4 3/4] mm: Drop first_index/last_index in zap_details Peter Xu
2021-09-24 4:14 ` Hugh Dickins
2021-09-15 18:15 ` [PATCH v4 4/4] mm: Add zap_skip_check_mapping() helper Peter Xu
2021-09-24 4:44 ` Hugh Dickins
2021-09-24 10:11 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104143440.d0056137ee07d3e96d6b56ec@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=apopple@nvidia.com \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill@shutemov.name \
--cc=liam.howlett@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox