From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E54D7C433EF for ; Mon, 1 Nov 2021 21:51:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A7E260FC4 for ; Mon, 1 Nov 2021 21:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A7E260FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 00C1394002D; Mon, 1 Nov 2021 17:51:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFEA594002B; Mon, 1 Nov 2021 17:50:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E13CD94002D; Mon, 1 Nov 2021 17:50:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id D14FE94002B for ; Mon, 1 Nov 2021 17:50:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8885C8249980 for ; Mon, 1 Nov 2021 21:50:59 +0000 (UTC) X-FDA: 78761707038.23.015F0B1 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP id 6DAC4150453A for ; Mon, 1 Nov 2021 21:50:51 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id EE86B60EE3; Mon, 1 Nov 2021 21:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635803458; bh=LjQ+jv2pb1lXnkT/NVcDdURxhVA9PsUtmE/QNpSNqg4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=N6FQT6aVm4GMhI9nzrGsysH7nvafcXJaJ68z06dNDXo9ZYtqm7kQwr7/6hgLvth97 B2cDyAu7xEEWRlY/E5USrwrSW/MbV6+60CBtUR1Dz0KV3yE9KjvupadXKDPiUVb87K r/lTvbZ5bvD8SEQ6/nfn/oEN26qQNqCie9q2OvJFP6oNHNjTCLkDjRNEbP32uibVRp 6RhNQUpmKoKnZoplursOROiGTZSORTMFfE6/q+jOHbTVZf2QYiba5GV/5YWankapHg tDNDo9Wxgm3UiilWVJddCweCqsEjdS+Lh+ZqjoRR209vsLWIdGqBPJKFJpOUSWuGlJ VYbSRfM/eKqig== Date: Mon, 1 Nov 2021 16:50:56 -0500 From: Bjorn Helgaas To: Christoph Hellwig Cc: dan.j.williams@intel.com, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2] memremap: remove support for external pgmap refcounts Message-ID: <20211101215056.GA552989@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211028151017.50234-1-hch@lst.de> Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N6FQT6aV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of helgaas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=helgaas@kernel.org X-Rspamd-Server: rspam03 X-Stat-Signature: br5eyhihnahpjmjwty6tayxzzdnnkecm X-Rspamd-Queue-Id: 6DAC4150453A X-HE-Tag: 1635803451-428725 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 28, 2021 at 05:10:17PM +0200, Christoph Hellwig wrote: > No driver is left using the external pgmap refcount, so remove the > code to support it. > > Signed-off-by: Christoph Hellwig Acked-by: Bjorn Helgaas > diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c > index 50cdde3e9a8b2..316fd2f44df45 100644 > --- a/drivers/pci/p2pdma.c > +++ b/drivers/pci/p2pdma.c > @@ -219,7 +219,7 @@ int pci_p2pdma_add_resource(struct pci_dev *pdev, int bar, size_t size, > error = gen_pool_add_owner(p2pdma->pool, (unsigned long)addr, > pci_bus_address(pdev, bar) + offset, > range_len(&pgmap->range), dev_to_node(&pdev->dev), > - pgmap->ref); > + &pgmap->ref); I assume the change above is safe because of the one below. > struct dev_pagemap { > struct vmem_altmap altmap; > - struct percpu_ref *ref; > - struct percpu_ref internal_ref; > + struct percpu_ref ref;