From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBDBC433F5 for ; Mon, 1 Nov 2021 16:06:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11F1D610D2 for ; Mon, 1 Nov 2021 16:06:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 11F1D610D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9386894001F; Mon, 1 Nov 2021 12:06:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C0EC94000F; Mon, 1 Nov 2021 12:06:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7888594001F; Mon, 1 Nov 2021 12:06:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 6497D94000F for ; Mon, 1 Nov 2021 12:06:44 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 11D6830148 for ; Mon, 1 Nov 2021 16:06:44 +0000 (UTC) X-FDA: 78760839486.29.44436F3 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP id CF7D1D0000B0 for ; Mon, 1 Nov 2021 16:06:35 +0000 (UTC) Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D66A610FC; Mon, 1 Nov 2021 16:06:39 +0000 (UTC) Date: Mon, 1 Nov 2021 12:06:36 -0400 From: Steven Rostedt To: Petr Mladek Cc: Yafang Shao , Andrew Morton , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Peter Zijlstra , Al Viro , Valentin Schneider , Qiang Zhang , robdclark , christian , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , David Miller , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot Subject: Re: [PATCH v7 00/11] extend task comm from 16 to 24 Message-ID: <20211101120636.3cfc5afa@gandalf.local.home> In-Reply-To: References: <20211101060419.4682-1-laoar.shao@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CF7D1D0000B0 X-Stat-Signature: tqfu537ramnqb75kibr643ra3k1995ab Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of "SRS0=3kpc=PU=goodmis.org=rostedt@kernel.org" designates 198.145.29.99 as permitted sender) smtp.mailfrom="SRS0=3kpc=PU=goodmis.org=rostedt@kernel.org" X-HE-Tag: 1635782795-798679 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 1 Nov 2021 17:02:12 +0100 Petr Mladek wrote: > > I thought Steven[1] and Kees[2] have already clearly explained why we > > do it like that, so I didn't give any more words on it. > > > > [1]. https://lore.kernel.org/all/20211025170503.59830a43@gandalf.local.home/ > > Steven was against switching task->comm[16] into a dynamically > allocated pointer. But he was not against storing longer names > separately. Just to be clear. I was recommending that the comm[16] would still behave like it does today. Where it is truncated. But if the name is longer, it could be stored in a separate location if the caller wanted to know the full name. -- Steve