From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CABC433FE for ; Fri, 29 Oct 2021 07:22:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 828C560238 for ; Fri, 29 Oct 2021 07:22:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 828C560238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1FE516B0071; Fri, 29 Oct 2021 03:22:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AE0B6B0072; Fri, 29 Oct 2021 03:22:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09DED6B0073; Fri, 29 Oct 2021 03:22:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id D0E586B0071 for ; Fri, 29 Oct 2021 03:22:28 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7711732080 for ; Fri, 29 Oct 2021 07:22:28 +0000 (UTC) X-FDA: 78748632018.01.363A503 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id 0BEE6F00038F for ; Fri, 29 Oct 2021 07:22:27 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6BD9260238; Fri, 29 Oct 2021 07:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635492146; bh=t8ppdzxFsp5v6Zb0J/RKUojmjtwxmCEGZi+MQ8JGgOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=kswy1uGbZzYi1OJpZnZFuB0Dvsd1IRbA77F9rQLFZ+HRpAIJUNPfoZrNZYvr9Cu68 HvoSd8nkmPd0SvlwB0x3LgFSYmQ7MiqAra+1b+cB32fGM2+jUfUaZN6XbkHuKAsSTb tFUmzlUje84/OMP31t7V19xB+bBHAsEsoNDkSJfWY5QkNHOBr5cse2Z/fQFO1U0TId tfsec9b0NZIZw7mK/Z9esrCY0004bJmmFcOH7iN4J1BDXFatw3ZlySoe8v+CivzmTc Fs+rHS+SrUpyvfJzuKGksX/Gj5tb50MdfuN1llGbQKkWD+6orW5yMgOhBmTDfOxVgh /mlwXMLKcUxEQ== From: SeongJae Park To: Changbin Du Cc: Andrew Morton , SeongJae Park , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: remove return value from before_terminate callback Date: Fri, 29 Oct 2021 07:22:18 +0000 Message-Id: <20211029072218.16880-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211029005023.8895-1-changbin.du@gmail.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0BEE6F00038F X-Stat-Signature: yqtzc6ffphyt5ors7tmwapsf5q38q9xd Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kswy1uGb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org X-HE-Tag: 1635492147-6293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 29 Oct 2021 08:50:23 +0800 Changbin Du wrote: > Since the return value of 'before_terminate' callback is never used, > we make it have no return value. > > Signed-off-by: Changbin Du Thank you for this patch! Reviewed-by: SeongJae Park Thanks, SJ > --- > include/linux/damon.h | 2 +- > mm/damon/dbgfs.c | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index 50c6eb0dee1f..041966786270 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -322,7 +322,7 @@ struct damon_callback { > int (*before_start)(struct damon_ctx *context); > int (*after_sampling)(struct damon_ctx *context); > int (*after_aggregation)(struct damon_ctx *context); > - int (*before_terminate)(struct damon_ctx *context); > + void (*before_terminate)(struct damon_ctx *context); > }; > > /** > diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c > index befb27a29aab..eccc14b34901 100644 > --- a/mm/damon/dbgfs.c > +++ b/mm/damon/dbgfs.c > @@ -645,18 +645,17 @@ static void dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx) > debugfs_create_file(file_names[i], 0600, dir, ctx, fops[i]); > } > > -static int dbgfs_before_terminate(struct damon_ctx *ctx) > +static void dbgfs_before_terminate(struct damon_ctx *ctx) > { > struct damon_target *t, *next; > > if (!targetid_is_pid(ctx)) > - return 0; > + return; > > damon_for_each_target_safe(t, next, ctx) { > put_pid((struct pid *)t->id); > damon_destroy_target(t); > } > - return 0; > } > > static struct damon_ctx *dbgfs_new_ctx(void) > -- > 2.32.0