Re: [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions

linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed

* Re: [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions
       [not found] <20211027150324.79827-1-andriy.shevchenko@linux.intel.com>
@ 2021-10-27 23:15 ` kernel test robot
  2021-10-27 23:43   ` Andrew Morton
  2021-10-28  2:36 ` kernel test robot
  1 sibling, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-10-27 23:15 UTC (permalink / raw)
  To: Andy Shevchenko, linux-kernel
  Cc: kbuild-all, Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 2708 bytes --]

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on hnaz-mm/master linus/master v5.15-rc7 next-20211027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fd321f3d5b18ccab48b82ee4099ae79961067fdc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
        git checkout fd321f3d5b18ccab48b82ee4099ae79961067fdc
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/media/dvb-frontends/cxd2880/cxd2880_common.c: In function 'cxd2880_convert2s_complement':
>> drivers/media/dvb-frontends/cxd2880/cxd2880_common.c:18:30: error: implicit declaration of function 'GENMASK' [-Werror=implicit-function-declaration]
      18 |                 return (int)(GENMASK(31, bitlen) | value);
         |                              ^~~~~~~
   cc1: all warnings being treated as errors


vim +/GENMASK +18 drivers/media/dvb-frontends/cxd2880/cxd2880_common.c

1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  11  
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  12  int cxd2880_convert2s_complement(u32 value, u32 bitlen)
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  13  {
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  14  	if (!bitlen || bitlen >= 32)
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  15  		return (int)value;
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  16  
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  17  	if (value & (u32)(1 << (bitlen - 1)))
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18 @18  		return (int)(GENMASK(31, bitlen) | value);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61666 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions
  2021-10-27 23:15 ` [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions kernel test robot
@ 2021-10-27 23:43   ` Andrew Morton
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2021-10-27 23:43 UTC (permalink / raw)
  To: kernel test robot
  Cc: Andy Shevchenko, linux-kernel, kbuild-all, Linux Memory Management List

On Thu, 28 Oct 2021 07:15:13 +0800 kernel test robot <lkp@intel.com> wrote:

> Hi Andy,
> 
> I love your patch! Yet something to improve:

Thanks.

> [auto build test ERROR on linux/master]
> [also build test ERROR on hnaz-mm/master linus/master v5.15-rc7 next-20211027]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/fd321f3d5b18ccab48b82ee4099ae79961067fdc
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
>         git checkout fd321f3d5b18ccab48b82ee4099ae79961067fdc
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/media/dvb-frontends/cxd2880/cxd2880_common.c: In function 'cxd2880_convert2s_complement':
> >> drivers/media/dvb-frontends/cxd2880/cxd2880_common.c:18:30: error: implicit declaration of function 'GENMASK' [-Werror=implicit-function-declaration]
>       18 |                 return (int)(GENMASK(31, bitlen) | value);
>          |                              ^~~~~~~

--- a/drivers/media/dvb-frontends/cxd2880/cxd2880_common.h~delay-replace-kernelh-with-the-necessary-inclusions-fix
+++ a/drivers/media/dvb-frontends/cxd2880/cxd2880_common.h
@@ -12,6 +12,7 @@
 #include <linux/types.h>
 #include <linux/errno.h>
 #include <linux/delay.h>
+#include <linux/bits.h>
 #include <linux/string.h>
 
 int cxd2880_convert2s_complement(u32 value, u32 bitlen);
_



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions
       [not found] <20211027150324.79827-1-andriy.shevchenko@linux.intel.com>
  2021-10-27 23:15 ` [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions kernel test robot
@ 2021-10-28  2:36 ` kernel test robot
  1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-10-28  2:36 UTC (permalink / raw)
  To: Andy Shevchenko, linux-kernel
  Cc: llvm, kbuild-all, Andrew Morton, Linux Memory Management List

[-- Attachment #1: Type: text/plain, Size: 2670 bytes --]

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.15-rc7 next-20211027]
[cannot apply to hnaz-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
config: x86_64-randconfig-a004-20211027 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5db7568a6a1fcb408eb8988abdaff2a225a8eb72)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fd321f3d5b18ccab48b82ee4099ae79961067fdc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
        git checkout fd321f3d5b18ccab48b82ee4099ae79961067fdc
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/dvb-frontends/cxd2880/cxd2880_common.c:18:16: error: implicit declaration of function 'GENMASK' [-Werror,-Wimplicit-function-declaration]
                   return (int)(GENMASK(31, bitlen) | value);
                                ^
   1 error generated.


vim +/GENMASK +18 drivers/media/dvb-frontends/cxd2880/cxd2880_common.c

1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  11  
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  12  int cxd2880_convert2s_complement(u32 value, u32 bitlen)
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  13  {
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  14  	if (!bitlen || bitlen >= 32)
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  15  		return (int)value;
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  16  
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  17  	if (value & (u32)(1 << (bitlen - 1)))
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18 @18  		return (int)(GENMASK(31, bitlen) | value);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33334 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-28  2:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211027150324.79827-1-andriy.shevchenko@linux.intel.com>
2021-10-27 23:15 ` [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions kernel test robot
2021-10-27 23:43   ` Andrew Morton
2021-10-28  2:36 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox