Re: [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 28 Oct 2021 07:15:13 +0800 kernel test robot <lkp@intel.com> wrote:

> Hi Andy,
> 
> I love your patch! Yet something to improve:

Thanks.

> [auto build test ERROR on linux/master]
> [also build test ERROR on hnaz-mm/master linus/master v5.15-rc7 next-20211027]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/fd321f3d5b18ccab48b82ee4099ae79961067fdc
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
>         git checkout fd321f3d5b18ccab48b82ee4099ae79961067fdc
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/media/dvb-frontends/cxd2880/cxd2880_common.c: In function 'cxd2880_convert2s_complement':
> >> drivers/media/dvb-frontends/cxd2880/cxd2880_common.c:18:30: error: implicit declaration of function 'GENMASK' [-Werror=implicit-function-declaration]
>       18 |                 return (int)(GENMASK(31, bitlen) | value);
>          |                              ^~~~~~~

--- a/drivers/media/dvb-frontends/cxd2880/cxd2880_common.h~delay-replace-kernelh-with-the-necessary-inclusions-fix
+++ a/drivers/media/dvb-frontends/cxd2880/cxd2880_common.h
@@ -12,6 +12,7 @@
 #include <linux/types.h>
 #include <linux/errno.h>
 #include <linux/delay.h>
+#include <linux/bits.h>
 #include <linux/string.h>
 
 int cxd2880_convert2s_complement(u32 value, u32 bitlen);
_