From: Andrew Morton <akpm@linux-foundation.org>
To: Yang Shi <shy828301@gmail.com>
Cc: Song Liu <songliubraving@fb.com>, Hugh Dickins <hughd@google.com>,
"sunhao.th@gmail.com" <sunhao.th@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"andrea.righi@canonical.com" <andrea.righi@canonical.com>,
Linux Memory Management List <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] mm: khugepaged: skip huge page collapse for special files
Date: Wed, 27 Oct 2021 13:53:28 -0700 [thread overview]
Message-ID: <20211027135328.001e4582a9535e8e4be785bb@linux-foundation.org> (raw)
In-Reply-To: <CAHbLzkqTW9U3VvTu1Ki5v_cLRC9gHW+znBukg_ycergE0JWj-A@mail.gmail.com>
On Wed, 27 Oct 2021 13:44:37 -0700 Yang Shi <shy828301@gmail.com> wrote:
> > > --- a/mm/khugepaged.c
> > > +++ b/mm/khugepaged.c
> > > @@ -445,22 +445,25 @@ static bool hugepage_vma_check(struct vm_area_struct *vma,
> > > if (!transhuge_vma_enabled(vma, vm_flags))
> > > return false;
> > >
> > > - /* Enabled via shmem mount options or sysfs settings. */
> > > - if (shmem_file(vma->vm_file) && shmem_huge_enabled(vma)) {
> > > + if (vma->vm_file)
> > > return IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff,
> > > HPAGE_PMD_NR);
> >
> > Am I misreading this? If we return here for vma->vm_file, the following
> > logic (shmem_file(), etc.) would be skipped, no?
>
> Oh, yes, you are right. My mistake.
>
> Andrew,
>
> Could you please apply the below fix?
um, how well tested are these changes?
next prev parent reply other threads:[~2021-10-27 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 19:52 Yang Shi
2021-10-27 20:34 ` Song Liu
2021-10-27 20:44 ` Yang Shi
2021-10-27 20:53 ` Andrew Morton [this message]
2021-10-27 21:57 ` Yang Shi
2021-10-27 20:50 ` Matthew Wilcox
2021-10-27 21:32 ` Yang Shi
2021-10-27 21:37 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027135328.001e4582a9535e8e4be785bb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrea.righi@canonical.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=sunhao.th@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox