linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Ahmed S. Darwish" <a.darwish@linutronix.de>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [linux-next:master 7919/11322] net/sched/sch_gred.c:350:1: warning: the frame size of 1168 bytes is larger than 1024 bytes
Date: Tue, 26 Oct 2021 14:21:20 +0800	[thread overview]
Message-ID: <202110261405.a2hjhHFy-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4947 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9ae1fbdeabd3b3f668ad0bcb47d64b3a9fb4f8fc
commit: 67c9e6270f3013e4d86ec57c4e7f27459f2a0652 [7919/11322] net: sched: Protect Qdisc::bstats with u64_stats
config: mips-randconfig-r006-20211025 (attached as .config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=67c9e6270f3013e4d86ec57c4e7f27459f2a0652
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 67c9e6270f3013e4d86ec57c4e7f27459f2a0652
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   net/sched/sch_gred.c: In function 'gred_offload':
>> net/sched/sch_gred.c:350:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     350 | }
         | ^


vim +350 net/sched/sch_gred.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  309  
890d8d23ec3c9e Jakub Kicinski 2018-11-19  310  static void gred_offload(struct Qdisc *sch, enum tc_gred_command command)
890d8d23ec3c9e Jakub Kicinski 2018-11-19  311  {
890d8d23ec3c9e Jakub Kicinski 2018-11-19  312  	struct gred_sched *table = qdisc_priv(sch);
890d8d23ec3c9e Jakub Kicinski 2018-11-19  313  	struct net_device *dev = qdisc_dev(sch);
890d8d23ec3c9e Jakub Kicinski 2018-11-19  314  	struct tc_gred_qopt_offload opt = {
890d8d23ec3c9e Jakub Kicinski 2018-11-19  315  		.command	= command,
890d8d23ec3c9e Jakub Kicinski 2018-11-19  316  		.handle		= sch->handle,
890d8d23ec3c9e Jakub Kicinski 2018-11-19  317  		.parent		= sch->parent,
890d8d23ec3c9e Jakub Kicinski 2018-11-19  318  	};
890d8d23ec3c9e Jakub Kicinski 2018-11-19  319  
890d8d23ec3c9e Jakub Kicinski 2018-11-19  320  	if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc)
890d8d23ec3c9e Jakub Kicinski 2018-11-19  321  		return;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  322  
890d8d23ec3c9e Jakub Kicinski 2018-11-19  323  	if (command == TC_GRED_REPLACE) {
890d8d23ec3c9e Jakub Kicinski 2018-11-19  324  		unsigned int i;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  325  
890d8d23ec3c9e Jakub Kicinski 2018-11-19  326  		opt.set.grio_on = gred_rio_mode(table);
890d8d23ec3c9e Jakub Kicinski 2018-11-19  327  		opt.set.wred_on = gred_wred_mode(table);
890d8d23ec3c9e Jakub Kicinski 2018-11-19  328  		opt.set.dp_cnt = table->DPs;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  329  		opt.set.dp_def = table->def;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  330  
890d8d23ec3c9e Jakub Kicinski 2018-11-19  331  		for (i = 0; i < table->DPs; i++) {
890d8d23ec3c9e Jakub Kicinski 2018-11-19  332  			struct gred_sched_data *q = table->tab[i];
890d8d23ec3c9e Jakub Kicinski 2018-11-19  333  
890d8d23ec3c9e Jakub Kicinski 2018-11-19  334  			if (!q)
890d8d23ec3c9e Jakub Kicinski 2018-11-19  335  				continue;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  336  			opt.set.tab[i].present = true;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  337  			opt.set.tab[i].limit = q->limit;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  338  			opt.set.tab[i].prio = q->prio;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  339  			opt.set.tab[i].min = q->parms.qth_min >> q->parms.Wlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  340  			opt.set.tab[i].max = q->parms.qth_max >> q->parms.Wlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  341  			opt.set.tab[i].is_ecn = gred_use_ecn(q);
890d8d23ec3c9e Jakub Kicinski 2018-11-19  342  			opt.set.tab[i].is_harddrop = gred_use_harddrop(q);
890d8d23ec3c9e Jakub Kicinski 2018-11-19  343  			opt.set.tab[i].probability = q->parms.max_P;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  344  			opt.set.tab[i].backlog = &q->backlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  345  		}
890d8d23ec3c9e Jakub Kicinski 2018-11-19  346  		opt.set.qstats = &sch->qstats;
890d8d23ec3c9e Jakub Kicinski 2018-11-19  347  	}
890d8d23ec3c9e Jakub Kicinski 2018-11-19  348  
890d8d23ec3c9e Jakub Kicinski 2018-11-19  349  	dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_QDISC_GRED, &opt);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 @350  }
890d8d23ec3c9e Jakub Kicinski 2018-11-19  351  

:::::: The code at line 350 was first introduced by commit
:::::: 890d8d23ec3c9eca847be0593c0cf5f650b97271 net: sched: gred: add basic Qdisc offload

:::::: TO: Jakub Kicinski <jakub.kicinski@netronome.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38436 bytes --]

                 reply	other threads:[~2021-10-26  6:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110261405.a2hjhHFy-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=a.darwish@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox