From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Cc: <akpm@linux-foundation.org>, <sj@kernel.org>
Subject: [PATCH -next] mm/damon: fix error return code in damon_reclaim_turn()
Date: Mon, 25 Oct 2021 20:45:00 +0800 [thread overview]
Message-ID: <20211025124500.2758060-1-yangyingliang@huawei.com> (raw)
If damon_reclaim_new_scheme() fails, it should return
error code in damon_reclaim_turn()
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
mm/damon/reclaim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index f5ae4c422555..dc1485044eaf 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -292,8 +292,10 @@ static int damon_reclaim_turn(bool on)
/* Will be freed by 'damon_set_schemes()' below */
scheme = damon_reclaim_new_scheme();
- if (!scheme)
+ if (!scheme) {
+ err = -ENOMEM;
goto free_region_out;
+ }
err = damon_set_schemes(ctx, &scheme, 1);
if (err)
goto free_scheme_out;
--
2.25.1
next reply other threads:[~2021-10-25 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:45 Yang Yingliang [this message]
2021-10-25 13:30 ` SeongJae Park
2021-10-26 7:06 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025124500.2758060-1-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox