From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EFCC433EF for ; Fri, 22 Oct 2021 08:51:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE75A610A4 for ; Fri, 22 Oct 2021 08:51:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE75A610A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 60F1F900003; Fri, 22 Oct 2021 04:51:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BEBA900002; Fri, 22 Oct 2021 04:51:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45F79900003; Fri, 22 Oct 2021 04:51:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 35AEC900002 for ; Fri, 22 Oct 2021 04:51:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E5886181EC4BA for ; Fri, 22 Oct 2021 08:51:08 +0000 (UTC) X-FDA: 78723453816.01.FB0777F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf11.hostedemail.com (Postfix) with ESMTP id 8B7F6F0000BA for ; Fri, 22 Oct 2021 08:51:08 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 9B89D21983; Fri, 22 Oct 2021 08:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634892667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3ksDUVgqu2ftprEqG94t5YEqIhESu4luf8I6VL1DNaI=; b=CQcAvWNESWel7EWMMd6TsJoRUGnMm2kiFiobu0/FbxUPn2c1igWXUdRQEsysDf/Y98CAMJ Z/GoDzTkg0iXlPPQVBq6M9LYaF8fG/gzSrfJQQhKNlvXkTw31Qum7yoZicJZWBYE7wOLrL uSEx4p0+zkP9feR/ttBHn+5DNbLniwU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634892667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3ksDUVgqu2ftprEqG94t5YEqIhESu4luf8I6VL1DNaI=; b=0mAIE+x7gXvCG2AbrrlMVUmzDJdK4g0TNfeujizgWuIqKH/rrFsTdZj6Wjc1agzQMCBi1F dDBoPS9/BzjnWRBQ== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id 86A6AA3B83; Fri, 22 Oct 2021 08:51:07 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 45DFD1E11B6; Fri, 22 Oct 2021 10:51:07 +0200 (CEST) Date: Fri, 22 Oct 2021 10:51:07 +0200 From: Jan Kara To: Christoph Hellwig Cc: Andrew Morton , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jan Kara , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/5] mm: don't automatically unregister bdis Message-ID: <20211022085107.GE1026@quack2.suse.cz> References: <20211021124441.668816-1-hch@lst.de> <20211021124441.668816-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021124441.668816-5-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8B7F6F0000BA X-Stat-Signature: 5hymhxuhdhmuc7pweg6ndfe73ykjz6cz Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CQcAvWNE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0mAIE+x7; spf=pass (imf11.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-HE-Tag: 1634892668-192904 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 21-10-21 14:44:40, Christoph Hellwig wrote: > All BDI users now unregister explicitly. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/backing-dev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index 8a46a0a4b72fa..768e9ae489f66 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -965,8 +965,7 @@ static void release_bdi(struct kref *ref) > struct backing_dev_info *bdi = > container_of(ref, struct backing_dev_info, refcnt); > > - if (test_bit(WB_registered, &bdi->wb.state)) > - bdi_unregister(bdi); > + WARN_ON_ONCE(test_bit(WB_registered, &bdi->wb.state)); > WARN_ON_ONCE(bdi->dev); > wb_exit(&bdi->wb); > kfree(bdi); > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR