From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B749C433EF for ; Fri, 22 Oct 2021 08:48:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C9CBE610A8 for ; Fri, 22 Oct 2021 08:48:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C9CBE610A8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 57563900003; Fri, 22 Oct 2021 04:48:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 524EF900002; Fri, 22 Oct 2021 04:48:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41429900003; Fri, 22 Oct 2021 04:48:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id EF890900002 for ; Fri, 22 Oct 2021 04:48:44 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9B05227753 for ; Fri, 22 Oct 2021 08:48:44 +0000 (UTC) X-FDA: 78723447768.22.F3791C9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf07.hostedemail.com (Postfix) with ESMTP id CD98510000B8 for ; Fri, 22 Oct 2021 08:48:48 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 0A2DC2199B; Fri, 22 Oct 2021 08:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634892523; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3eOyqjTYeSFpI90LY5QA2iYYQmlUyWdBLPJTQWj8wBU=; b=AMTs2nvqN3QiOl5gydTNg3F6JaH5KE7/rT7bQCOZ/DwyP0r60NHvx65BnJ//D8YArVhM6b dmbUaruaNaewNcCQiuYTGZowIL8Of+SyxvBKkr2nSrJF1iCkRBg8XtEiaEtqiqB74RRzvs KPBnfOYuWMVkqWNjiA9JB+9Lh+chuUc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634892523; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3eOyqjTYeSFpI90LY5QA2iYYQmlUyWdBLPJTQWj8wBU=; b=ptFu8OPTAXe92AJJt59WAAQn0sQvjyiIumwrX+lHPLhNrb8Q6XClnpyINKeGqhN29O10gf sa6ExXevSG/IZxBw== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id EAC60A3B83; Fri, 22 Oct 2021 08:48:42 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id A073F1E11B6; Fri, 22 Oct 2021 10:48:41 +0200 (CEST) Date: Fri, 22 Oct 2021 10:48:41 +0200 From: Jan Kara To: Christoph Hellwig Cc: Andrew Morton , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jan Kara , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/5] fs: explicitly unregister per-superblock BDIs Message-ID: <20211022084841.GD1026@quack2.suse.cz> References: <20211021124441.668816-1-hch@lst.de> <20211021124441.668816-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021124441.668816-4-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CD98510000B8 X-Stat-Signature: uhxrjwusdurcx3jifx93xs5e5qafbu3w Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AMTs2nvq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ptFu8OPT; dmarc=none; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz X-HE-Tag: 1634892528-135155 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 21-10-21 14:44:39, Christoph Hellwig wrote: > Add a new SB_I_ flag to mark superblocks that have an ephemeral bdi > associated with them, an unregister it when the superblock is shut down. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/super.c | 3 +++ > include/linux/fs.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/fs/super.c b/fs/super.c > index bcef3a6f4c4b5..3bfc0f8fbd5bc 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -476,6 +476,8 @@ void generic_shutdown_super(struct super_block *sb) > spin_unlock(&sb_lock); > up_write(&sb->s_umount); > if (sb->s_bdi != &noop_backing_dev_info) { > + if (sb->s_iflags & SB_I_PERSB_BDI) > + bdi_unregister(sb->s_bdi); > bdi_put(sb->s_bdi); > sb->s_bdi = &noop_backing_dev_info; > } > @@ -1562,6 +1564,7 @@ int super_setup_bdi_name(struct super_block *sb, char *fmt, ...) > } > WARN_ON(sb->s_bdi != &noop_backing_dev_info); > sb->s_bdi = bdi; > + sb->s_iflags |= SB_I_PERSB_BDI; > > return 0; > } > diff --git a/include/linux/fs.h b/include/linux/fs.h > index e7a633353fd20..226de651f52e6 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1443,6 +1443,7 @@ extern int send_sigurg(struct fown_struct *fown); > #define SB_I_UNTRUSTED_MOUNTER 0x00000040 > > #define SB_I_SKIP_SYNC 0x00000100 /* Skip superblock at global sync */ > +#define SB_I_PERSB_BDI 0x00000200 /* has a per-sb bdi */ > > /* Possible states of 'frozen' field */ > enum { > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR