From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 070ACC433F5 for ; Fri, 22 Oct 2021 08:43:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C28C60232 for ; Fri, 22 Oct 2021 08:43:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C28C60232 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3A5DE900003; Fri, 22 Oct 2021 04:43:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 355C8900002; Fri, 22 Oct 2021 04:43:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F73B900003; Fri, 22 Oct 2021 04:43:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 12741900002 for ; Fri, 22 Oct 2021 04:43:31 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BACC62D4B9 for ; Fri, 22 Oct 2021 08:43:30 +0000 (UTC) X-FDA: 78723434580.14.396875C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf20.hostedemail.com (Postfix) with ESMTP id 508F4D0000B6 for ; Fri, 22 Oct 2021 08:43:26 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 36A742199D; Fri, 22 Oct 2021 08:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1634892209; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MPkk1brJOSm3Yjvf8eNKc5Xgdk5rE0s6Q0mFNwK3L0=; b=ZMgBrFjusXhaQPvK4lMGfW8pXzkvKAK+UxUiULhKMhxkYb1mTnk8Zdhzg1GwrOyWIxHWkc kdzWCb2bwehDGt+xBCWTiTp1Z9JGCXx54IVfYNFRC8zcgnQsdXrl0eKT+yqI5o61q0bhxm wUn3zesrnmC1osXdKtqdsHWOaulzil0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1634892209; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MPkk1brJOSm3Yjvf8eNKc5Xgdk5rE0s6Q0mFNwK3L0=; b=TPdYz8+hWK/Ce1UG2jCycUaJtBnbYQH4tCu3Vq3bhGRhGxbe9zhN1RiuqAVr+EUmo9Rxpz 5D5RHngYDLqEVaBA== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id 2849BA3B83; Fri, 22 Oct 2021 08:43:29 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id B2C731E11B6; Fri, 22 Oct 2021 10:43:25 +0200 (CEST) Date: Fri, 22 Oct 2021 10:43:25 +0200 From: Jan Kara To: Christoph Hellwig Cc: Andrew Morton , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Jan Kara , linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/5] mtd: call bdi_unregister explicitly Message-ID: <20211022084325.GC1026@quack2.suse.cz> References: <20211021124441.668816-1-hch@lst.de> <20211021124441.668816-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021124441.668816-3-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: r1y7t1mhmkt3aa3ib6de5c83gde8w5kn Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZMgBrFju; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TPdYz8+h; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 508F4D0000B6 X-HE-Tag: 1634892206-720887 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 21-10-21 14:44:38, Christoph Hellwig wrote: > Call bdi_unregister explicitly instead of relying on the automatic > unregistration. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > drivers/mtd/mtdcore.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index c8fd7f758938b..c904e23c82379 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -2409,6 +2409,7 @@ static void __exit cleanup_mtd(void) > if (proc_mtd) > remove_proc_entry("mtd", NULL); > class_unregister(&mtd_class); > + bdi_unregister(mtd_bdi); > bdi_put(mtd_bdi); > idr_destroy(&mtd_idr); > } > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR