From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E09C433F5 for ; Fri, 22 Oct 2021 03:26:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6FEE3619E4 for ; Fri, 22 Oct 2021 03:26:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6FEE3619E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D20E294000E; Thu, 21 Oct 2021 23:26:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD149900002; Thu, 21 Oct 2021 23:26:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B702A94000E; Thu, 21 Oct 2021 23:26:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id A0C1F900002 for ; Thu, 21 Oct 2021 23:26:56 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 676672D4C1 for ; Fri, 22 Oct 2021 03:26:56 +0000 (UTC) X-FDA: 78722636832.30.035CCC6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP id 8F55EF00008C for ; Fri, 22 Oct 2021 03:26:52 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A3D38619BB; Fri, 22 Oct 2021 03:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1634873214; bh=dzVTEjYRvmGezdHFFYtBNFqE16zf9YNbNz8le8VBIjQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qdc4pnTlrUjTjgzU9JkiOX5K4g7nVlz54G5x2dfMNCsUi4hCl90buh+usFnbV1R2F CrfX+ZulE3uxYnvhDwezjEltulhqzRqs2LAI7LRWlnrfMObRLBTbMeQy3n8U+oVTIR gAErfhkmBP0FJcCoSvVeWEhOksaf2C+dFRRxpfGY= Date: Thu, 21 Oct 2021 20:26:52 -0700 From: Andrew Morton To: Chen Wandun Cc: , , , , , , , Subject: Re: [PATCH v3 2/2] mm/vmalloc: introduce alloc_pages_bulk_array_mempolicy to accelerate memory allocation Message-Id: <20211021202652.ff8568bd5d58fbcf32946f83@linux-foundation.org> In-Reply-To: <20211021080744.874701-3-chenwandun@huawei.com> References: <20211021080744.874701-1-chenwandun@huawei.com> <20211021080744.874701-3-chenwandun@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8F55EF00008C X-Stat-Signature: mbo8xn9dekygks5mdbwr3w7599jauue1 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Qdc4pnTl; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1634873212-306876 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 21 Oct 2021 16:07:44 +0800 Chen Wandun wrote: > It What is "it"? > will cause significant performance regressions in some situations > as Andrew mentioned in [1]. The main situation is vmalloc, vmalloc > will allocate pages with NUMA_NO_NODE by default, that will result > in alloc page one by one; > > In order to solve this, __alloc_pages_bulk and mempolicy should be > considered at the same time. > > 1) If node is specified in memory allocation request, it will alloc > all pages by __alloc_pages_bulk. > > 2) If interleaving allocate memory, it will cauculate how many pages > should be allocated in each node, and use __alloc_pages_bulk to alloc > pages in each node. This v3 patch didn't incorporate my two fixes, below. It is usual to incorporate such fixes prior to resending. I have retained those two fixes, now against v3. From: Andrew Morton Subject: mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation-fix make two functions static Cc: Chen Wandun Cc: Eric Dumazet Cc: Hanjun Guo Cc: Kefeng Wang Cc: Nicholas Piggin Cc: Shakeel Butt Cc: Uladzislau Rezki (Sony) Signed-off-by: Andrew Morton --- mm/mempolicy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/mm/mempolicy.c~mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation-fix +++ a/mm/mempolicy.c @@ -2196,7 +2196,7 @@ struct page *alloc_pages(gfp_t gfp, unsi } EXPORT_SYMBOL(alloc_pages); -unsigned long alloc_pages_bulk_array_interleave(gfp_t gfp, +static unsigned long alloc_pages_bulk_array_interleave(gfp_t gfp, struct mempolicy *pol, unsigned long nr_pages, struct page **page_array) { @@ -2231,7 +2231,7 @@ unsigned long alloc_pages_bulk_array_int return total_allocated; } -unsigned long alloc_pages_bulk_array_preferred_many(gfp_t gfp, int nid, +static unsigned long alloc_pages_bulk_array_preferred_many(gfp_t gfp, int nid, struct mempolicy *pol, unsigned long nr_pages, struct page **page_array) { _ From: Andrew Morton Subject: mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation-fix-2 fix CONFIG_NUMA=n build. alloc_pages_bulk_array_mempolicy() was undefined Cc: Chen Wandun Cc: Eric Dumazet Cc: Hanjun Guo Cc: Kefeng Wang Cc: Nicholas Piggin Cc: Uladzislau Rezki (Sony) Signed-off-by: Andrew Morton --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/vmalloc.c~mm-vmalloc-introduce-alloc_pages_bulk_array_mempolicy-to-accelerate-memory-allocation-fix-2 +++ a/mm/vmalloc.c @@ -2860,7 +2860,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, * otherwise memory may be allocated in only one node, * but mempolcy want to alloc memory by interleaving. */ - if (nid == NUMA_NO_NODE) + if (IS_ENABLED(CONFIG_NUMA) && nid == NUMA_NO_NODE) nr = alloc_pages_bulk_array_mempolicy(gfp, nr_pages_request, pages + nr_allocated); _