From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E88C433F5 for ; Wed, 20 Oct 2021 19:24:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E27C861354 for ; Wed, 20 Oct 2021 19:24:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E27C861354 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2F0F76B0081; Wed, 20 Oct 2021 15:24:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29F26940007; Wed, 20 Oct 2021 15:24:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 167076B0083; Wed, 20 Oct 2021 15:24:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 09CF66B0081 for ; Wed, 20 Oct 2021 15:24:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ADB1B181AF5D3 for ; Wed, 20 Oct 2021 19:24:36 +0000 (UTC) X-FDA: 78717792552.14.FBA2C8B Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf06.hostedemail.com (Postfix) with ESMTP id 91FA5801A8A3 for ; Wed, 20 Oct 2021 19:24:35 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id s19so611328ljj.11 for ; Wed, 20 Oct 2021 12:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zBVYuwbzU0MrjoGITQu9tBsWZ7nbrws+z0zkrHM73ZE=; b=TWJxQV5pYR5GhzFo4ccC4tOo8Wfgvjfb2t4pbpy2+KtzAiCW5plYXo44STxngIpVBg I2pO3atCIiMB0X5qiITyxrGa8nKQ14zhgMz+2uj3xT07LbOUKUc7L8cdJshp67Jvz2mx E/Q9RzBO4s1JziAjRicKhfSphkeyAPRvn5yTibuokpMIRll6117L6OPPyz0L7nTkEKy1 dMNWl1WBd6z/rMRsj6kpU22KM1oFvILYESgm0xtQMvE3Y/icJopqJJ2dxlN0NNbu9Ios zk6pVsUCYWftFXBIqUFI164dO6N+bA3uZQJ+d3qWROqcMeSNG3R6vk93nHrBGT/ky6IC s2+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zBVYuwbzU0MrjoGITQu9tBsWZ7nbrws+z0zkrHM73ZE=; b=vvoxrCjX3pr0JFK7B9EBn5S22BTglpDt1TcfmpYSrX63PeDVcOq1E9YeSHDTzxCeAe elSmgZFjl9SX/ASFylzOWL0m8xBpnuLqEiXoJrBKJJJ9wFMt7LxQ+h53+p63nqCZ8xpE a9m1x5vWOziw7J4Fwj8VIMWCW+1F7oQ8h68daEgk3ZqL4tjfp+9HyUmlnZCx62ez1LiF xjlnyyPi6L2+AsI8XCfX2WagZbmsoCmO1lAHi/I5Y2Y+xlKok8f8Jefd2LTyFrLE18bA TajZHU90JW9GLYu/AQ6v5ZN5WnWfyMc9EgJPayiyrgTV+rEbao8HhWhfAfyurp1Aslko vDgg== X-Gm-Message-State: AOAM5331/wzxx9eFrzv2GmHHfCaeJrWaWaGuYv3hgS5ywK0/bIER+76i NIT867HwBtrECSG2M/S9awI= X-Google-Smtp-Source: ABdhPJyrm9VQo0GMaJxs62rwrDCG0Alik60ONtJwaI27umRlQFC625Te5ewPe0yeMXu+xQrVwJXh8A== X-Received: by 2002:a2e:8e72:: with SMTP id t18mr952563ljk.189.1634757874664; Wed, 20 Oct 2021 12:24:34 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id bp25sm260772lfb.64.2021.10.20.12.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:24:33 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 20 Oct 2021 21:24:30 +0200 To: Michal Hocko Cc: Michal Hocko , Linux Memory Management List , Dave Chinner , Neil Brown , Andrew Morton , Christoph Hellwig , linux-fsdevel@vger.kernel.org, LKML , Ilya Dryomov , Jeff Layton Subject: Re: [RFC 2/3] mm/vmalloc: add support for __GFP_NOFAIL Message-ID: <20211020192430.GA1861@pc638.lan> References: <20211018114712.9802-3-mhocko@kernel.org> <20211019110649.GA1933@pc638.lan> <20211019194658.GA1787@pc638.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 91FA5801A8A3 X-Stat-Signature: bjozykmuqk6t3jd3s6mjrne5zj138qhp Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TWJxQV5p; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com X-HE-Tag: 1634757875-349237 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 20, 2021 at 05:00:28PM +0200, Uladzislau Rezki wrote: > > > > On Wed 20-10-21 16:29:14, Uladzislau Rezki wrote: > > > On Wed, Oct 20, 2021 at 4:06 PM Michal Hocko wrote: > > [...] > > > > As I've said I am OK with either of the two. Do you or anybody have any > > > > preference? Without any explicit event to wake up for neither of the two > > > > is more than just an optimistic retry. > > > > > > > From power perspective it is better to have a delay, so i tend to say > > > that delay is better. > > > > I am a terrible random number generator. Can you give me a number > > please? > > > Well, we can start from one jiffy so it is one timer tick: schedule_timeout(1) > A small nit, it is better to replace it by the simple msleep() call: msleep(jiffies_to_msecs(1)); -- Vlad Rezki