From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBF9C433F5 for ; Wed, 20 Oct 2021 08:12:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC7DF610E6 for ; Wed, 20 Oct 2021 08:12:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC7DF610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 65F4B6B0071; Wed, 20 Oct 2021 04:12:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E7D4900002; Wed, 20 Oct 2021 04:12:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 488C86B0073; Wed, 20 Oct 2021 04:12:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 32A216B0071 for ; Wed, 20 Oct 2021 04:12:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DBD472BC13 for ; Wed, 20 Oct 2021 08:12:37 +0000 (UTC) X-FDA: 78716099154.20.B0B0836 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id 6BB61F00038D for ; Wed, 20 Oct 2021 08:12:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E2C2B60F46; Wed, 20 Oct 2021 08:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634717556; bh=RK6eiA3Ff133h/eqM6N0sgj9Q8kr6wnbFVmSUumeQMc=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=qNecR+mfFmE26/nylO0Fu1aiROA68Uqz6uJ0blGytlE+ib5ghmLvgoar7MQ71R9kv M5H0PmpJwtEIg6IQKGqNzvLbb12eL75ajLMbHju0GgSTDkhfwceGc5BYSt4+fWPD72 i0oNqbgy7yC7Er2Qb3BrBqCnxjBMh475M0sKlC7ttJrKQO8mZfRZ2InBjSnLkunEmG uI67NlePP+suxEDaX+5HKsfe8R5c/khwTIfXzxt1WgE2X/NIm3yhrkK+BaN245f5WN 5A/qDy5M5FCwM9ZtOM2+m+vOW6uUcpCr8tna2Trv0h6QTxSaqWtoxDL0nm1KNncAF2 Igu6DqbiAdfAA== From: SeongJae Park To: SeongJae Park Cc: Xin Hao , sjpark@amazon.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] mm/damon/dbgfs: Add adaptive_targets list check before enable monitor_on Date: Wed, 20 Oct 2021 08:12:33 +0000 Message-Id: <20211020081233.28363-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211020072121.17166-1-sj@kernel.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6BB61F00038D X-Stat-Signature: wbkh9yuodh147zbnt76c7fufoh1pfydz Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qNecR+mf; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1634717557-388436 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 20 Oct 2021 07:21:21 +0000 SeongJae Park wrote: > On Wed, 20 Oct 2021 09:42:33 +0800 Xin Hao wrote: > > > When the ctx->adaptive_targets list is empty, > > I did some test on monitor_on interface like this. > > > > # echo > /sys/kernel/debug/damon/target_ids > > Thanks for the change, but you missed writing 'on' to 'monitor_on' in the above > example. > > > > > Though the ctx->adaptive_targets list is empty, but the > > kthread_run still be called, and the kdamond.x thread still > > be created, this is meaningless. > > > > So there adds a judgment in 'dbgfs_monitor_on_write', > > if the ctx->adaptive_targets list is empty, return -EINVAL. > > > > Signed-off-by: Xin Hao > > Other parts looks good to me. However, seems this commit conflicts with a > patch[1] which already merged in -mm tree. Could you please rebase this on it? > FYI, all DAMON patches that merged in -mm tree are also applied on DAMON > development tree. So, you could get the patch applied tree by: > > $ git remote add sj git://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git > $ git fetch sj > $ git checkout 0fa378d04b12 > > [1] https://lore.kernel.org/linux-mm/20211014073014.35754-1-sj@kernel.org/ > > > Thanks, > SJ > > > --- > > include/linux/damon.h | 1 + > > mm/damon/core.c | 5 +++++ > > mm/damon/dbgfs.c | 13 ++++++++++--- > > 3 files changed, 16 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/damon.h b/include/linux/damon.h > > index 715dadd21f7c..4fce5f1f6dad 100644 > > --- a/include/linux/damon.h > > +++ b/include/linux/damon.h > > @@ -316,6 +316,7 @@ void damon_destroy_scheme(struct damos *s); > > > > struct damon_target *damon_new_target(unsigned long id); > > void damon_add_target(struct damon_ctx *ctx, struct damon_target *t); > > +bool damon_targets_empty(struct damon_ctx *ctx); > > void damon_free_target(struct damon_target *t); > > void damon_destroy_target(struct damon_target *t); > > unsigned int damon_nr_regions(struct damon_target *t); > > diff --git a/mm/damon/core.c b/mm/damon/core.c > > index 2f6785737902..c3a1374dbe0b 100644 > > --- a/mm/damon/core.c > > +++ b/mm/damon/core.c > > @@ -156,6 +156,11 @@ void damon_add_target(struct damon_ctx *ctx, struct damon_target *t) > > list_add_tail(&t->list, &ctx->adaptive_targets); > > } > > > > +bool damon_targets_empty(struct damon_ctx *ctx) > > +{ > > + return list_empty(&ctx->adaptive_targets); > > +} > > + > > static void damon_del_target(struct damon_target *t) > > { > > list_del(&t->list); > > diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c > > index 38188347d8ab..9dee29f7d103 100644 > > --- a/mm/damon/dbgfs.c > > +++ b/mm/damon/dbgfs.c > > @@ -865,12 +865,19 @@ static ssize_t dbgfs_monitor_on_write(struct file *file, > > return -EINVAL; > > } > > > > - if (!strncmp(kbuf, "on", count)) > > + if (!strncmp(kbuf, "on", count)) { > > + int i; > > + > > + for (i = 0; i < dbgfs_nr_ctxs; i++) { > > + if (damon_targets_empty(dbgfs_ctxs[i])) > > + return -EINVAL; Oops, I forgot that you should 'kfree(kbuf)' before returning here. Please do that. Thanks, SJ > > + } > > err = damon_start(dbgfs_ctxs, dbgfs_nr_ctxs); > > - else if (!strncmp(kbuf, "off", count)) > > + } else if (!strncmp(kbuf, "off", count)) { > > err = damon_stop(dbgfs_ctxs, dbgfs_nr_ctxs); > > - else > > + } else { > > err = -EINVAL; > > + } > > > > if (err) > > ret = err; > > -- > > 2.31.0 > >