From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3819BC433F5 for ; Wed, 20 Oct 2021 07:02:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDF58600EF for ; Wed, 20 Oct 2021 07:02:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DDF58600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5C3956B0071; Wed, 20 Oct 2021 03:02:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 572EE6B0072; Wed, 20 Oct 2021 03:02:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4615C900002; Wed, 20 Oct 2021 03:02:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 3389C6B0071 for ; Wed, 20 Oct 2021 03:02:20 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C3A29180ACF9A for ; Wed, 20 Oct 2021 07:02:19 +0000 (UTC) X-FDA: 78715921998.15.206D547 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id 72881801AB36 for ; Wed, 20 Oct 2021 07:01:18 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DD480610EA; Wed, 20 Oct 2021 07:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634713276; bh=4/mLAWSfmQ5N31lrDoW0CUf2EeHX/XzEZDiUHcEYofA=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=trC3nGm37uTj0pLjFOOKHVFeGWNBCxoncvyCXP2r9DZ/1lyppCKqzus+tvvQ7JQe4 EOoIqrsgkNkC4NiggbsPses73JgAfai8uSSE/n/a5WwHmu26Ud2gz8PJe37g8ZEviU 1yxGbuS2GU+Lxuz3SA9562V08FBIAdXItzAPpoDiNLtthThW144czrnD0wOjosxQe3 Eo6x13DSvM9KIqilb20miV1f2fd2Bh4mf4eszz9CGq+egmNuyJh9sid5cY+EAYgBG/ e2wbbVvlZ7de9p3q/r7pdwKAxsoh59KDJMCtFva2jQQvhLzzXYvN0lz9b8OdeIufLx J9jrkbnYfFrcA== From: SeongJae Park To: Xin Hao Cc: sjpark@amazon.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm/damon: Remove unnecessary variable initialization Date: Wed, 20 Oct 2021 07:01:13 +0000 Message-Id: <20211020070113.18392-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 72881801AB36 X-Stat-Signature: 3eobw6fi36d7opfi431tie19iao658ip Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=trC3nGm3; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1634713278-713290 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 20 Oct 2021 09:42:32 +0800 Xin Hao wrote: > In 'damon_va_apply_three_regions', There is no > need to set variable 'i' as 0 > > Signed-off-by: Xin Hao I gave you my 'Reviewed-by:' for the last version of this patch, but seems you missed putting it here. So, I'm giving it here again ;) Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/vaddr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index b8ba44f69db6..90be463efff7 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -305,7 +305,7 @@ static void damon_va_apply_three_regions(struct damon_target *t, > struct damon_addr_range bregions[3]) > { > struct damon_region *r, *next; > - unsigned int i = 0; > + unsigned int i; > > /* Remove regions which are not in the three big regions now */ > damon_for_each_region_safe(r, next, t) { > -- > 2.31.0