linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: akpm@linux-foundation.org
Cc: SeongJae Park <sj@kernel.org>,
	Jonathan.Cameron@Huawei.com, amit@kernel.org,
	benh@kernel.crashing.org, corbet@lwn.net, david@redhat.com,
	dwmw@amazon.com, elver@google.com, foersleo@amazon.de,
	gthelen@google.com, markubo@amazon.de, rientjes@google.com,
	shakeelb@google.com, shuah@kernel.org, linux-damon@amazon.com,
	linux-mm@kvack.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 09/15] mm/damon/dbgfs: Support prioritization weights
Date: Tue, 19 Oct 2021 15:07:25 +0000	[thread overview]
Message-ID: <20211019150731.16699-10-sj@kernel.org> (raw)
In-Reply-To: <20211019150731.16699-1-sj@kernel.org>

This commit allows DAMON debugfs interface users set the prioritization
weights by putting three more numbers to the 'schemes' file.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/dbgfs.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c
index 097e6745ba75..20c4feb8b918 100644
--- a/mm/damon/dbgfs.c
+++ b/mm/damon/dbgfs.c
@@ -105,13 +105,16 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len)
 
 	damon_for_each_scheme(s, c) {
 		rc = scnprintf(&buf[written], len - written,
-				"%lu %lu %u %u %u %u %d %lu %lu %lu %lu %lu\n",
+				"%lu %lu %u %u %u %u %d %lu %lu %lu %u %u %u %lu %lu\n",
 				s->min_sz_region, s->max_sz_region,
 				s->min_nr_accesses, s->max_nr_accesses,
 				s->min_age_region, s->max_age_region,
 				s->action,
 				s->quota.ms, s->quota.sz,
 				s->quota.reset_interval,
+				s->quota.weight_sz,
+				s->quota.weight_nr_accesses,
+				s->quota.weight_age,
 				s->stat_count, s->stat_sz);
 		if (!rc)
 			return -ENOMEM;
@@ -193,11 +196,14 @@ static struct damos **str_to_schemes(const char *str, ssize_t len,
 	while (pos < len && *nr_schemes < max_nr_schemes) {
 		struct damos_quota quota = {};
 
-		ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u %lu %lu %lu%n",
+		ret = sscanf(&str[pos],
+				"%lu %lu %u %u %u %u %u %lu %lu %lu %u %u %u%n",
 				&min_sz, &max_sz, &min_nr_a, &max_nr_a,
 				&min_age, &max_age, &action, &quota.ms,
-				&quota.sz, &quota.reset_interval, &parsed);
-		if (ret != 10)
+				&quota.sz, &quota.reset_interval,
+				&quota.weight_sz, &quota.weight_nr_accesses,
+				&quota.weight_age, &parsed);
+		if (ret != 13)
 			break;
 		if (!damos_action_valid(action)) {
 			pr_err("wrong action %d\n", action);
-- 
2.17.1



  parent reply	other threads:[~2021-10-19 15:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 15:07 [PATCH 00/15] Introduce DAMON-based Proactive Reclamation SeongJae Park
2021-10-19 15:07 ` [PATCH 01/15] mm/damon/paddr: Support the pageout scheme SeongJae Park
2021-10-19 15:07 ` [PATCH 02/15] mm/damon/schemes: Implement size quota for schemes application speed control SeongJae Park
2021-10-19 15:07 ` [PATCH 03/15] mm/damon/schemes: Skip already charged targets and regions SeongJae Park
2021-10-19 15:07 ` [PATCH 04/15] mm/damon/schemes: Implement time quota SeongJae Park
2021-10-19 15:07 ` [PATCH 05/15] mm/damon/dbgfs: Support quotas of schemes SeongJae Park
2021-10-19 15:07 ` [PATCH 06/15] mm/damon/selftests: Support schemes quotas SeongJae Park
2021-10-19 15:07 ` [PATCH 07/15] mm/damon/schemes: Prioritize regions within the quotas SeongJae Park
2021-10-19 15:07 ` [PATCH 08/15] mm/damon/vaddr,paddr: Support pageout prioritization SeongJae Park
2021-10-19 15:07 ` SeongJae Park [this message]
2021-10-19 15:07 ` [PATCH 10/15] tools/selftests/damon: Update for regions prioritization of schemes SeongJae Park
2021-10-19 15:07 ` [PATCH 11/15] mm/damon/schemes: Activate schemes based on a watermarks mechanism SeongJae Park
2021-10-19 15:07 ` [PATCH 12/15] mm/damon/dbgfs: Support watermarks SeongJae Park
2021-10-19 15:07 ` [PATCH 13/15] selftests/damon: " SeongJae Park
2021-10-19 15:07 ` [PATCH 14/15] mm/damon: Introduce DAMON-based Reclamation (DAMON_RECLAIM) SeongJae Park
2021-10-19 15:07 ` [PATCH 15/15] Documentation/admin-guide/mm/damon: Add a document for DAMON_RECLAIM SeongJae Park
2021-11-21 22:32 ` [PATCH 00/15] Introduce DAMON-based Proactive Reclamation Oleksandr Natalenko
2021-11-23  8:36   ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019150731.16699-10-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=dwmw@amazon.com \
    --cc=elver@google.com \
    --cc=foersleo@amazon.de \
    --cc=gthelen@google.com \
    --cc=linux-damon@amazon.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=markubo@amazon.de \
    --cc=rientjes@google.com \
    --cc=shakeelb@google.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox