From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4B8C433FE for ; Tue, 19 Oct 2021 10:32:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 565B060F59 for ; Tue, 19 Oct 2021 10:32:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 565B060F59 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wangsu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E619C6B006C; Tue, 19 Oct 2021 06:32:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E11DD900003; Tue, 19 Oct 2021 06:32:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D00A9900002; Tue, 19 Oct 2021 06:32:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id C1D906B006C for ; Tue, 19 Oct 2021 06:32:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 780C41829546D for ; Tue, 19 Oct 2021 10:32:54 +0000 (UTC) X-FDA: 78712823868.07.0A2DC82 Received: from zg8tmty1ljiyny4xntqumjca.icoremail.net (zg8tmty1ljiyny4xntqumjca.icoremail.net [165.227.154.27]) by imf13.hostedemail.com (Postfix) with SMTP id 75C0410400EA for ; Tue, 19 Oct 2021 10:32:49 +0000 (UTC) Received: from fedora33.wangsu.com (unknown [59.61.78.138]) by app2 (Coremail) with SMTP id 4zNnewD3HeTKnm5h5ogBAA--.3005S2; Tue, 19 Oct 2021 18:32:47 +0800 (CST) From: Lin Feng To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linf@wangsu.com Subject: [PATCH] mm: vmstat.c: make extfrag_index show more pretty Date: Tue, 19 Oct 2021 18:32:41 +0800 Message-Id: <20211019103241.134797-1-linf@wangsu.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-CM-TRANSID:4zNnewD3HeTKnm5h5ogBAA--.3005S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Zw4rGrWrZw18CFyfGF15Arb_yoW8Gw4Upr 4YyF1UJw15GFy7Jw17t3W8Jw1Ut3WkGF18JrW5Xr18Zr1UAr1jyr17trW7tF1DJa4DJrW5 JF4xJw1Utr1xt37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnUUvcSsGvfC2KfnxnUUI43ZEXa7xR_UUUUUUUUU== X-CM-SenderInfo: holqwq5zdqw23xof0z/ X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 75C0410400EA X-Stat-Signature: tp7e9mn4xecbuz9dzyeo8z5eoffs5z67 Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of linf@wangsu.com has no SPF policy when checking 165.227.154.27) smtp.mailfrom=linf@wangsu.com X-HE-Tag: 1634639569-156042 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.001567, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: fragmentation_index may return -1000 and the corresponding formated value showed by seq_printf will take a negative signatrue, but other positive formated values don't take a positive signatrue, so the output becomes unaligned. before: Node 0, zone DMA -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 -1= .000 -1.000 -1.000 -1.000 Node 0, zone DMA32 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 -1= .000 -1.000 -1.000 -1.000 Node 0, zone Normal -1.000 -1.000 -1.000 -1.000 0.931 0.966 0.983 0.992= 0.996 0.998 0.999 after this patch: Node 0, zone DMA -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 -1= .000 -1.000 -1.000 -1.000 Node 0, zone DMA32 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 -1.000 -1= .000 -1.000 -1.000 -1.000 Node 0, zone Normal -1.000 -1.000 -1.000 -1.000 0.931 0.966 0.983 0= .992 0.996 0.998 0.999 Signed-off-by: Lin Feng --- mm/vmstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 8ce2620344b2..263d367d193b 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -2179,7 +2179,7 @@ static void extfrag_show_print(struct seq_file *m, for (order =3D 0; order < MAX_ORDER; ++order) { fill_contig_page_info(zone, order, &info); index =3D __fragmentation_index(order, &info); - seq_printf(m, "%d.%03d ", index / 1000, index % 1000); + seq_printf(m, "%2d.%03d ", index / 1000, index % 1000); } =20 seq_putc(m, '\n'); --=20 2.31.1