From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7579C433EF for ; Fri, 15 Oct 2021 21:34:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A5CF6109E for ; Fri, 15 Oct 2021 21:34:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6A5CF6109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0003E6B006C; Fri, 15 Oct 2021 17:34:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF263900002; Fri, 15 Oct 2021 17:34:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E08086B0075; Fri, 15 Oct 2021 17:34:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id CFCC16B006C for ; Fri, 15 Oct 2021 17:34:09 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7AF261809AEFC for ; Fri, 15 Oct 2021 21:34:09 +0000 (UTC) X-FDA: 78699975018.32.49E8FBC Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP id EA49EF00008C for ; Fri, 15 Oct 2021 21:34:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A42DB60EE2; Fri, 15 Oct 2021 21:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1634333648; bh=2tyMLoz7LKioqYzGr2VimJ9SCcxFOLwmrLyZHfNoTNw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lZ8cYv7MXOGE5rKlvl0Do+7ZT7bSOjmWHroiiJBLfDCL6UeFaGIzT70s7XAJH5fks +8JKp9BXhuxBMHZZHmwEfGqkAdlB7NSmh88Rr/Vf++ZVs7WjILD8ypwD2bPFaita53 mqQ+VLZNgENPu9qhJneMQi8dw6fXy4mtb9+AzkoQ= Date: Fri, 15 Oct 2021 14:34:05 -0700 From: Andrew Morton To: Vasily Averin Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Shakeel Butt , Mel Gorman , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@openvz.org Subject: Re: [PATCH mm v5] memcg: enable memory accounting in __alloc_pages_bulk Message-Id: <20211015143405.b7d54e4afa4ca7b2d57b6140@linux-foundation.org> In-Reply-To: <65c1afaf-7947-ce28-55b7-06bde7aeb278@virtuozzo.com> References: <0baa2b26-a41b-acab-b75d-72ec241f5151@virtuozzo.com> <65c1afaf-7947-ce28-55b7-06bde7aeb278@virtuozzo.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EA49EF00008C X-Stat-Signature: icdcrgdn3izbwi5jhubbtthazwserayo Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lZ8cYv7M; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1634333647-994329 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 14 Oct 2021 11:02:57 +0300 Vasily Averin wrote: > Bulk page allocator is used in vmalloc where it can be called > with __GFP_ACCOUNT and must charge allocated pages into memory cgroup. Is this problem serious enough to justify -stable backporting? Some words which explaining reasoning for the backport would be helpful. This patch makes Shakeel's "memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT" unnecessary. Which should we use?