From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A7AC4332F for ; Thu, 14 Oct 2021 19:16:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20C5361151 for ; Thu, 14 Oct 2021 19:16:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 20C5361151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C1D8E900003; Thu, 14 Oct 2021 15:16:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCD97900002; Thu, 14 Oct 2021 15:16:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A95A7900003; Thu, 14 Oct 2021 15:16:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 99794900002 for ; Thu, 14 Oct 2021 15:16:25 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 419F682499B9 for ; Thu, 14 Oct 2021 19:16:25 +0000 (UTC) X-FDA: 78695999130.30.5CBE191 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf08.hostedemail.com (Postfix) with ESMTP id 08F5730000AB for ; Thu, 14 Oct 2021 19:16:23 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id 66so6405393pgc.9 for ; Thu, 14 Oct 2021 12:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YY4rRYrBdBk9JxylDDW+2MAnqVHDh/g91wQSCjGEN3A=; b=ZTatkiV+zrVwKLUnasRwkpFNpr7/o2XY28zcF67FFhF+pC/7r2ARJFUqLPtxOoPbFG BEksFd4gGAj6siRu5BltbiFR1izTOrNoTz0Rvd+1J9eTovkKQ3Epom44OCjZ5R90Jyqi I4jLrHIS1WCmrM6H1sPLNGwQvQueW4WIDqykOK3C2IjAVZ0cX8xxqozjQkYXnUySnCaP z6ev500+1bgIG67r+ykneaMyOM10O166SrXbR8+Ow7+SKZFTcb4oMYlZD5PK12ghW6c0 tyKTzeTxfEKbgyRbNblUjrR8qfym56YfXGJqIx9+f4a46vukcfGB7SZA+lOA7Mf7pE6y +8bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YY4rRYrBdBk9JxylDDW+2MAnqVHDh/g91wQSCjGEN3A=; b=A3Bp6jOYTaTz3x4nl9fxHbhszgOZeNLBXKm9DAfSXG5E1S4mVJna6Vvfe1ZVSDCsiv 1bAXfZ6bO+t7E80sSQHRwQJS4rVcO/x8dUYOcM+Ha1RLanlZ+F9FEx/CwySkWSOGZ2ig 5bM2kvnZOtyDVao3rUeLKr3PP/N5N+u0knr3Wm8GY97cfILRo3YZ/cvgJtll5qUNVd7L BmUmqnyJRss6Yp6KfaAwA+0ICi38KwHSxDVZopknTZUsRC6jgmvN1u3yM3Sr3uh0mEBN vvKmwSDSL6vbPM7+5m+m5+wF5Wx/fATI4941EPoa0Qz9tn56mvI0RVDqYwHSXT5f1CGc TlCQ== X-Gm-Message-State: AOAM530jE3T8csvaj67xur3VhBZAX7pVvWZanvEns2b3NIfg7IiTxviC KKfwt1YpXHIxVxXjXF3IMCQ= X-Google-Smtp-Source: ABdhPJxVrYI017AWLFsYOxZJWSp64W08P8F6AE0lo9NraLydbu+Vk25cRlc2twpldnxPi+rah6UZcA== X-Received: by 2002:aa7:88cc:0:b0:431:c124:52ba with SMTP id k12-20020aa788cc000000b00431c12452bamr7174421pff.63.1634238983964; Thu, 14 Oct 2021 12:16:23 -0700 (PDT) Received: from localhost.localdomain (c-73-93-239-127.hsd1.ca.comcast.net. [73.93.239.127]) by smtp.gmail.com with ESMTPSA id x129sm3253922pfc.140.2021.10.14.12.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 12:16:22 -0700 (PDT) From: Yang Shi To: naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, peterx@redhat.com, osalvador@suse.de, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [v4 PATCH 1/6] mm: hwpoison: remove the unnecessary THP check Date: Thu, 14 Oct 2021 12:16:10 -0700 Message-Id: <20211014191615.6674-2-shy828301@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20211014191615.6674-1-shy828301@gmail.com> References: <20211014191615.6674-1-shy828301@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 08F5730000AB X-Stat-Signature: kmj751i14p6tzi3wfoewiph6r7bs1hiu Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZTatkiV+; spf=pass (imf08.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1634238983-566553 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When handling THP hwpoison checked if the THP is in allocation or free stage since hwpoison may mistreat it as hugetlb page. After commit 415c64c1453a ("mm/memory-failure: split thp earlier in memory erro= r handling") the problem has been fixed, so this check is no longer needed. Remove it. The side effect of the removal is hwpoison may report unsplit THP instead of unknown error for shmem THP. It seems not like a big deal. The following patch depends on this, which fixes shmem THP with hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be backported to -stable as well. Cc: Acked-by: Naoya Horiguchi Suggested-by: Naoya Horiguchi Signed-off-by: Yang Shi --- mm/memory-failure.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 3e6449f2102a..73f68699e7ab 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1147,20 +1147,6 @@ static int __get_hwpoison_page(struct page *page) if (!HWPoisonHandlable(head)) return -EBUSY; =20 - if (PageTransHuge(head)) { - /* - * Non anonymous thp exists only in allocation/free time. We - * can't handle such a case correctly, so let's give it up. - * This should be better than triggering BUG_ON when kernel - * tries to touch the "partially handled" page. - */ - if (!PageAnon(head)) { - pr_err("Memory failure: %#lx: non anonymous thp\n", - page_to_pfn(page)); - return 0; - } - } - if (get_page_unless_zero(head)) { if (head =3D=3D compound_head(page)) return 1; --=20 2.26.2