From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87DD2C43217 for ; Thu, 14 Oct 2021 11:18:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 47FE061130 for ; Thu, 14 Oct 2021 11:18:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 47FE061130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A1C7F6B006C; Thu, 14 Oct 2021 07:18:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A61B900002; Thu, 14 Oct 2021 07:18:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 892B66B0072; Thu, 14 Oct 2021 07:18:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 75D296B006C for ; Thu, 14 Oct 2021 07:18:46 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 256042C6A3 for ; Thu, 14 Oct 2021 11:18:46 +0000 (UTC) X-FDA: 78694795452.29.EC7DA98 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP id 2516D90000A6 for ; Thu, 14 Oct 2021 11:18:44 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CA4AB610E7; Thu, 14 Oct 2021 11:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634210324; bh=SLr0/jv6gdtWNXdULnzwbvVH9uCEqgkqQDU4gwtod5k=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=H2VZuDdlLfkyAYzo2+JSrGx7SrkiaqN/r7ahAN5Xh2n3ZRiSbjcOIpHPHLrW/2wyk AoNAQmq0U2SY3XkeugiiY+My6cQkxwfXHae7NdcgwuN4eq64hL3S9DcgddO+h8O1x0 V1LXHBKnZ1exGo0bmQKFHQLVIsdw3BU9PPK9QSh7dqSMptI3Z+tL0afEV0BkvgRfDQ Q/KJEgGnvcEYf7h0KA4n5musEP9BcYQ7j2rZoUIGqq1R2oDe7N3iMuyk4aK3y9ahgD jWOp7u5wGYBi+7L8jYpbhSsN7NTyODIn3E38VR7qEWWt1E969CL70Rk64AaY9hYsEO Yzncxab0+3R1A== From: SeongJae Park To: Randy Dunlap Cc: akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, SeongJae Park Subject: Re: mmotm 2021-10-13-19-52 uploaded (mm/damon/vaddr.c) Date: Thu, 14 Oct 2021 11:18:37 +0000 Message-Id: <20211014111837.5504-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 In-Reply-To: <2232228f-573b-ac19-1cb0-88690fdf6177@infradead.org> Content-Type: text/plain; charset=UTF-8 X-Rspamd-Queue-Id: 2516D90000A6 X-Stat-Signature: i8cpc1dpm4n7ubujht17obeugqknn6ns Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H2VZuDdl; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspamd-Server: rspam02 X-HE-Tag: 1634210324-415326 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Oct 2021 22:15:05 -0700 Randy Dunlap w= rote: > [-- Attachment #1: Type: text/plain, Size: 2271 bytes --] >=20 > On 10/13/21 7:52 PM, akpm@linux-foundation.org wrote: > > mmotm-readme.txt says > >=20 > > README for mm-of-the-moment: > >=20 > > https://www.ozlabs.org/~akpm/mmotm/ > >=20 > > This is a snapshot of my -mm patch queue. Uploaded at random hopeful= ly > > more than once a week. > >=20 > > You will need quilt to apply these patches to the latest Linus releas= e (5.x > > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicat= ed in > > https://ozlabs.org/~akpm/mmotm/series > >=20 > > The file broken-out.tar.gz contains two datestamp files: .DATE and > > .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-= ss, > > followed by the base kernel version against which this patch series i= s to > > be applied. >=20 > on i386: >=20 > In file included from ../include/linux/mm.h:33:0, > from ../include/linux/kallsyms.h:13, > from ../include/linux/bpf.h:20, > from ../include/linux/bpf-cgroup.h:5, > from ../include/linux/cgroup-defs.h:22, > from ../include/linux/cgroup.h:28, > from ../include/linux/hugetlb.h:9, > from ../mm/damon/vaddr.c:11: > ../mm/damon/vaddr.c: In function =E2=80=98damon_mkold_pmd_entry=E2=80=99= : > ../include/linux/pgtable.h:97:12: error: implicit declaration of functi= on =E2=80=98kmap_atomic=E2=80=99; did you mean =E2=80=98mcopy_atomic=E2=80= =99? [-Werror=3Dimplicit-function-declaration] > ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \ > ^ > ../include/linux/mm.h:2376:17: note: in expansion of macro =E2=80=98pte= _offset_map=E2=80=99 > pte_t *__pte =3D pte_offset_map(pmd, address); \ > ^~~~~~~~~~~~~~ > ../mm/damon/vaddr.c:387:8: note: in expansion of macro =E2=80=98pte_off= set_map_lock=E2=80=99 > pte =3D pte_offset_map_lock(walk->mm, pmd, addr, &ptl); > ^~~~~~~~~~~~~~~~~~~ > ../include/linux/pgtable.h:99:24: error: implicit declaration of functi= on =E2=80=98kunmap_atomic=E2=80=99; did you mean =E2=80=98in_atomic=E2=80= =99? [-Werror=3Dimplicit-function-declaration] > #define pte_unmap(pte) kunmap_atomic((pte)) > ^ > ../include/linux/mm.h:2384:2: note: in expansion of macro =E2=80=98pte_= unmap=E2=80=99 > pte_unmap(pte); \ > ^~~~~~~~~ > ../mm/damon/vaddr.c:392:2: note: in expansion of macro =E2=80=98pte_unm= ap_unlock=E2=80=99 > pte_unmap_unlock(pte, ptl); > ^~~~~~~~~~~~~~~~ >=20 >=20 > Full randconfig file is attached. Thank you for this report! I sent a fix: https://lore.kernel.org/linux-mm/20211014110848.5204-1-sj@kernel.org/ This was found and fixed by Andrew before, but I made this mistake again.= .. :'( To not repeat this again, I added a test for this case in DAMON correctne= ss tests: https://github.com/awslabs/damon-tests/commit/b3d1513ad16a Thanks, SJ >=20 > --=20 > ~Randy