From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2639C433FE for ; Wed, 13 Oct 2021 15:05:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 657B860F23 for ; Wed, 13 Oct 2021 15:05:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 657B860F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D93D3900004; Wed, 13 Oct 2021 11:05:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4353900002; Wed, 13 Oct 2021 11:05:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C32A1900004; Wed, 13 Oct 2021 11:05:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id B411B900002 for ; Wed, 13 Oct 2021 11:05:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5FC418249980 for ; Wed, 13 Oct 2021 15:05:54 +0000 (UTC) X-FDA: 78691739028.25.EE88260 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP id 9B38DF00716D for ; Wed, 13 Oct 2021 15:04:18 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B19E360F21; Wed, 13 Oct 2021 15:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634137458; bh=OrypIYAhYXa9wGUSvO8g91htORfmmNplHozAJSPJRq8=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=QMTmOAgehbBmBkuxpLwRuJQCocj1XYq90veQBVwSShzLDXMHz/dxQ6vXXb2+lMe1b So1xk0b70W/AwWB/m0LLU+chUlBtQJ+agLP8TMyBih4dB69CvJKZZi9pwiEWfyNg5p U/LZBsApH5FivMO8AkykYNRpvyHBq9Fok4JzZuTB5rL+6CSd/ZGCyw5ZtfWHzAtL6G ckb9SAwdOhrtEc2h4ac5LqjOHbbmIqK31jdb58wvKtdsRWZiW187DIGN7vEVz4cfVN HL42BEYQWOSA0NamQXYv7cS4kB7jg7fhp8Mj8KSYeNt2DnjmaV2mxxMn7dDCr5G2ga qx0XFsdU0HCUQ== From: SeongJae Park To: Rongwei Wang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, sj@kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/damon/dbgfs: remove unnecessary variables Date: Wed, 13 Oct 2021 15:04:13 +0000 Message-Id: <20211013150413.23027-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211013130901.1017-1-rongwei.wang@linux.alibaba.com> X-Rspamd-Queue-Id: 9B38DF00716D X-Stat-Signature: 9tdoirj4hk99oyjuzk73unxw1hq85nfb Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QMTmOAge; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-HE-Tag: 1634137458-749235 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Rongwei, Thank you for this patch! Looks good to me overall. I left a couple of nitpicks below, though. On Wed, 13 Oct 2021 21:09:01 +0800 Rongwei Wang wrote: [...] > @@ -352,7 +350,7 @@ static ssize_t dbgfs_target_ids_write(struct file *file, > > nrs = kbuf; > > - targets = str_to_target_ids(nrs, ret, &nr_targets); > + targets = str_to_target_ids(nrs, count, &nr_targets); > if (!targets) { > ret = -ENOMEM; > goto out; > @@ -378,12 +376,12 @@ static ssize_t dbgfs_target_ids_write(struct file *file, > goto unlock_out; > } > > - err = damon_set_targets(ctx, targets, nr_targets); > - if (err) { > + ret = damon_set_targets(ctx, targets, nr_targets); > + if (ret < 0) { I'd prefer 'if (ret) {', to be consistent with other part. > if (targetid_is_pid(ctx)) > dbgfs_put_pids(targets, nr_targets); > - ret = err; > - } > + } else > + ret = count; I'd prefer this to have braces: https://docs.kernel.org/process/coding-style.html#placing-braces-and-spaces > > unlock_out: > mutex_unlock(&ctx->kdamond_lock); > @@ -548,8 +546,7 @@ static ssize_t dbgfs_mk_context_write(struct file *file, [...] Thanks, SJ