From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93AF6C433EF for ; Wed, 13 Oct 2021 13:09:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D346610F8 for ; Wed, 13 Oct 2021 13:09:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1D346610F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A9BFA900002; Wed, 13 Oct 2021 09:09:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4B2A6B0071; Wed, 13 Oct 2021 09:09:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 961AB900002; Wed, 13 Oct 2021 09:09:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 8CDCE6B006C for ; Wed, 13 Oct 2021 09:09:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4D94F8249980 for ; Wed, 13 Oct 2021 13:09:09 +0000 (UTC) X-FDA: 78691444818.08.BDAF2F2 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 4C95CF000095 for ; Wed, 13 Oct 2021 13:09:06 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=rongwei.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UrhCxCT_1634130541; Received: from localhost.localdomain(mailfrom:rongwei.wang@linux.alibaba.com fp:SMTPD_---0UrhCxCT_1634130541) by smtp.aliyun-inc.com(127.0.0.1); Wed, 13 Oct 2021 21:09:02 +0800 From: Rongwei Wang To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: sj@kernel.org, akpm@linux-foundation.org Subject: [PATCH] mm/damon/dbgfs: remove unnecessary variables Date: Wed, 13 Oct 2021 21:09:01 +0800 Message-Id: <20211013130901.1017-1-rongwei.wang@linux.alibaba.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: 4C95CF000095 X-Stat-Signature: jchmx18gur9m65t6rg9t98xc173cgjya Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf16.hostedemail.com: domain of rongwei.wang@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=rongwei.wang@linux.alibaba.com X-Rspamd-Server: rspam06 X-HE-Tag: 1634130546-791022 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In some functions, it's unnecessary to declare 'err' and 'ret' variables at the same time. This patch mainly to simplify the issue of such declarations by reusing one variable. Signed-off-by: Rongwei Wang --- mm/damon/dbgfs.c | 67 ++++++++++++++++++++++-------------------------- 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index 28d6abf27763..d8dd68f72827 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -69,8 +69,7 @@ static ssize_t dbgfs_attrs_write(struct file *file, struct damon_ctx *ctx =3D file->private_data; unsigned long s, a, r, minr, maxr; char *kbuf; - ssize_t ret =3D count; - int err; + ssize_t ret; =20 kbuf =3D user_input_str(buf, count, ppos); if (IS_ERR(kbuf)) @@ -88,9 +87,9 @@ static ssize_t dbgfs_attrs_write(struct file *file, goto unlock_out; } =20 - err =3D damon_set_attrs(ctx, s, a, r, minr, maxr); - if (err) - ret =3D err; + ret =3D damon_set_attrs(ctx, s, a, r, minr, maxr); + if (!ret) + ret =3D count; unlock_out: mutex_unlock(&ctx->kdamond_lock); out: @@ -220,14 +219,13 @@ static ssize_t dbgfs_schemes_write(struct file *fil= e, const char __user *buf, struct damon_ctx *ctx =3D file->private_data; char *kbuf; struct damos **schemes; - ssize_t nr_schemes =3D 0, ret =3D count; - int err; + ssize_t nr_schemes =3D 0, ret; =20 kbuf =3D user_input_str(buf, count, ppos); if (IS_ERR(kbuf)) return PTR_ERR(kbuf); =20 - schemes =3D str_to_schemes(kbuf, ret, &nr_schemes); + schemes =3D str_to_schemes(kbuf, count, &nr_schemes); if (!schemes) { ret =3D -EINVAL; goto out; @@ -239,11 +237,12 @@ static ssize_t dbgfs_schemes_write(struct file *fil= e, const char __user *buf, goto unlock_out; } =20 - err =3D damon_set_schemes(ctx, schemes, nr_schemes); - if (err) - ret =3D err; - else + ret =3D damon_set_schemes(ctx, schemes, nr_schemes); + if (!ret) { + ret =3D count; nr_schemes =3D 0; + } + unlock_out: mutex_unlock(&ctx->kdamond_lock); free_schemes_arr(schemes, nr_schemes); @@ -342,9 +341,8 @@ static ssize_t dbgfs_target_ids_write(struct file *fi= le, char *kbuf, *nrs; unsigned long *targets; ssize_t nr_targets; - ssize_t ret =3D count; + ssize_t ret; int i; - int err; =20 kbuf =3D user_input_str(buf, count, ppos); if (IS_ERR(kbuf)) @@ -352,7 +350,7 @@ static ssize_t dbgfs_target_ids_write(struct file *fi= le, =20 nrs =3D kbuf; =20 - targets =3D str_to_target_ids(nrs, ret, &nr_targets); + targets =3D str_to_target_ids(nrs, count, &nr_targets); if (!targets) { ret =3D -ENOMEM; goto out; @@ -378,12 +376,12 @@ static ssize_t dbgfs_target_ids_write(struct file *= file, goto unlock_out; } =20 - err =3D damon_set_targets(ctx, targets, nr_targets); - if (err) { + ret =3D damon_set_targets(ctx, targets, nr_targets); + if (ret < 0) { if (targetid_is_pid(ctx)) dbgfs_put_pids(targets, nr_targets); - ret =3D err; - } + } else + ret =3D count; =20 unlock_out: mutex_unlock(&ctx->kdamond_lock); @@ -548,8 +546,7 @@ static ssize_t dbgfs_mk_context_write(struct file *fi= le, { char *kbuf; char *ctx_name; - ssize_t ret =3D count; - int err; + ssize_t ret; =20 kbuf =3D user_input_str(buf, count, ppos); if (IS_ERR(kbuf)) @@ -567,9 +564,9 @@ static ssize_t dbgfs_mk_context_write(struct file *fi= le, } =20 mutex_lock(&damon_dbgfs_lock); - err =3D dbgfs_mk_context(ctx_name); - if (err) - ret =3D err; + ret =3D dbgfs_mk_context(ctx_name); + if (!ret) + ret =3D count; mutex_unlock(&damon_dbgfs_lock); =20 out: @@ -638,8 +635,7 @@ static ssize_t dbgfs_rm_context_write(struct file *fi= le, const char __user *buf, size_t count, loff_t *ppos) { char *kbuf; - ssize_t ret =3D count; - int err; + ssize_t ret; char *ctx_name; =20 kbuf =3D user_input_str(buf, count, ppos); @@ -658,9 +654,9 @@ static ssize_t dbgfs_rm_context_write(struct file *fi= le, } =20 mutex_lock(&damon_dbgfs_lock); - err =3D dbgfs_rm_context(ctx_name); - if (err) - ret =3D err; + ret =3D dbgfs_rm_context(ctx_name); + if (!ret) + ret =3D count; mutex_unlock(&damon_dbgfs_lock); =20 out: @@ -684,9 +680,8 @@ static ssize_t dbgfs_monitor_on_read(struct file *fil= e, static ssize_t dbgfs_monitor_on_write(struct file *file, const char __user *buf, size_t count, loff_t *ppos) { - ssize_t ret =3D count; + ssize_t ret; char *kbuf; - int err; =20 kbuf =3D user_input_str(buf, count, ppos); if (IS_ERR(kbuf)) @@ -699,14 +694,14 @@ static ssize_t dbgfs_monitor_on_write(struct file *= file, } =20 if (!strncmp(kbuf, "on", count)) - err =3D damon_start(dbgfs_ctxs, dbgfs_nr_ctxs); + ret =3D damon_start(dbgfs_ctxs, dbgfs_nr_ctxs); else if (!strncmp(kbuf, "off", count)) - err =3D damon_stop(dbgfs_ctxs, dbgfs_nr_ctxs); + ret =3D damon_stop(dbgfs_ctxs, dbgfs_nr_ctxs); else - err =3D -EINVAL; + ret =3D -EINVAL; =20 - if (err) - ret =3D err; + if (!ret) + ret =3D count; kfree(kbuf); return ret; } --=20 2.27.0