From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7869C433EF for ; Wed, 13 Oct 2021 09:25:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 652E261040 for ; Wed, 13 Oct 2021 09:25:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 652E261040 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C5CA06B006C; Wed, 13 Oct 2021 05:25:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0C7E900002; Wed, 13 Oct 2021 05:25:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD3676B0072; Wed, 13 Oct 2021 05:25:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 99D006B006C for ; Wed, 13 Oct 2021 05:25:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F26611830BB6F for ; Wed, 13 Oct 2021 09:25:30 +0000 (UTC) X-FDA: 78690881220.04.8CE6FEF Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf14.hostedemail.com (Postfix) with ESMTP id 9B4706001982 for ; Wed, 13 Oct 2021 09:25:30 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id x27so8935363lfa.9 for ; Wed, 13 Oct 2021 02:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cCX5rYazwPKkV2adlibPw5BhMI4mGF7gTZdSyXGVIMk=; b=sfdextOyC2tky5pwOuFb4d5V9Xq+EVORiHJNACm6TXAU8vO8jJYV/l3WH3gazVC94Z IPMmHE2HNjun6pc8Hnu+gWjLH9+aRNTUIuw1VJxNMVPOEoc8A0Vfz1rfRWZiaxVSUVGz Hl3lKhaKc6nq3JHirqKygZCdHzHSCOUIDMJZlgB9Y9PE6xkZDEBh/517IMs0bBK7yBD+ SP6Wbfm21DPDUcxyBYDbyBUNDDTvLHyFvCRxSFd4iDxGnxiBI3EkZjh1zLXQ3AQC7HEK nWvSHeU5+xjfztDMJmkQ0ilwQN3ahwaF9+6EtNbDWgpthHvFl3uDvXkj0+WG6/7gNhyY OiZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cCX5rYazwPKkV2adlibPw5BhMI4mGF7gTZdSyXGVIMk=; b=1IdY5s3aLMT9AAbuBVXiyM8GR29iOvg44TdNLW2YP230NMmEnMOPTg5Abt3PKlYZLS +TU7gT12JQ1Kwtww3TWq6HqKT3NuqJ1wDPmogsnBWWPFZAzvRp5JBqMonTT19JxNDJ82 pyjBq5uBPlkn48JHGAA4GcWSVLN5QbNciRS9weR8PGbTpCi2ONd3mN/43z+o5nak4o+s SGZ7sK+z1i5bWBi/5cHKzdfjUhZ0of/Msp7suzcOffsB3PWyikjKGUNjDQ6SsZJ9gfsq Dz+uLUEd7cHsUsfEpo4E8JrNBa5UtXjrOezFl6flyWIdElsVOKD4HLymBsMLBKaABe0o h0BQ== X-Gm-Message-State: AOAM530RoJeJ14y5qatx3+UsvO98qcZ/FuioaSAcwcUgcagkiQFSoneZ /iZft9Y8mvwgQgks0O2H4LSMFQ== X-Google-Smtp-Source: ABdhPJwVJgFsivWlJ/XXlB2TuWiVZnog3MIEOMODLWfywNluSr+ei4k9NEWhstWTSL2gTz0/QqGLIw== X-Received: by 2002:a05:6512:1102:: with SMTP id l2mr38998317lfg.181.1634117128922; Wed, 13 Oct 2021 02:25:28 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id 9sm1411741ljo.78.2021.10.13.02.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 02:25:28 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 22E8110310E; Wed, 13 Oct 2021 12:25:30 +0300 (+03) Date: Wed, 13 Oct 2021 12:25:30 +0300 From: "Kirill A. Shutemov" To: "Matthew Wilcox (Oracle)" Cc: Yafang Shao , Sergey Senozhatsky , Petr Mladek , linux-mm@kvack.org, Vlastimil Babka , Rasmus Villemoes Subject: Re: [PATCH 2/5] test_printf: Assign all flags to page_flags Message-ID: <20211013092530.iidcseycqkn2b3vm@box.shutemov.name> References: <20211012182647.1605095-1-willy@infradead.org> <20211012182647.1605095-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012182647.1605095-3-willy@infradead.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9B4706001982 X-Stat-Signature: 57fiu7cyzyn96iijx6qabhao57em8kpf Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=sfdextOy; dmarc=none; spf=none (imf14.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.52) smtp.mailfrom=kirill@shutemov.name X-HE-Tag: 1634117130-315246 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 07:26:44PM +0100, Matthew Wilcox (Oracle) wrote: > Even unknown flags should be passed to %pGp so that we can test what it > does with them (today: nothing). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > lib/test_printf.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index a52c1c3a55ba..f744b0498672 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -608,14 +608,12 @@ page_flags_test(int section, int node, int zone, int last_cpupid, > int kasan_tag, int flags, const char *name, char *cmp_buf) > { > unsigned long values[] = {section, node, zone, last_cpupid, kasan_tag}; > - unsigned long page_flags = 0; > + unsigned long page_flags = flags; > unsigned long size = 0; > bool append = false; > int i; > > - flags &= PAGEFLAGS_MASK; > - if (flags) { > - page_flags |= flags; > + if (flags & PAGEFLAGS_MASK) { > snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name); > size = strlen(cmp_buf); > #if SECTIONS_WIDTH || NODES_WIDTH || ZONES_WIDTH || \ Do we even need 'page_flags'? Can't we do everything on 'flags' directly? -- Kirill A. Shutemov