From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBBAC433F5 for ; Wed, 13 Oct 2021 07:27:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 93D2B600EF for ; Wed, 13 Oct 2021 07:27:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 93D2B600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2CD3C940008; Wed, 13 Oct 2021 03:27:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27D16940007; Wed, 13 Oct 2021 03:27:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19311940008; Wed, 13 Oct 2021 03:27:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 08BCC940007 for ; Wed, 13 Oct 2021 03:27:22 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A94178249980 for ; Wed, 13 Oct 2021 07:27:21 +0000 (UTC) X-FDA: 78690583482.27.D515F85 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf04.hostedemail.com (Postfix) with ESMTP id 4BB9650000B3 for ; Wed, 13 Oct 2021 07:27:21 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id 21so1181011plo.13 for ; Wed, 13 Oct 2021 00:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=x1Ebcu4q4sojvBysK6NeK0lyMBpBy7CX3GptiOMMz40=; b=GbpddXjN019bQRXDXQj4kZZgfvpNA9cDk7qQs6S3vPQNLW6lsorFYr9g4BlfG8r+MH umScAii8wL7g7/Mjovb3dW34qcZ1nUli4UtJdgQXZQOIkLCSHGM6H+Tkjgjdjt6bH5od a+gBBBgtnRHNxhWlxeaphPwHSjnFpwXmEJLl8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=x1Ebcu4q4sojvBysK6NeK0lyMBpBy7CX3GptiOMMz40=; b=5HzPH3SyB2pd4ciN2uDX9GwvAZKTAhUzXKxLLd3skuB2BFuugr7aDyhiIT9Vj7d6hz k96kIqmS+6KjPkKHLh4jY0IchLVFikP7AnkNE/8YgRNQ/E1O2TY2HMYdRjTCwWnbF+9n 4KCo0iegz0MNkngL0vrjmVVhkE3Jccxkr6NrLOw3Il4UlnXBht6adEFvFqCJEXjyLoUv yycwvNFZ1uAirHq8C1Hs2ZqPmhR8/Xqqv9XE6y/6OIIu4OFqd+pu6xTBtUzrv/R1c50l 18Bn9gFK680TqPYr423jHRv/RGlDAu19NDWc4p0yG4h+lPAJ5Pj9eIVGHputcmPHSplx aE5A== X-Gm-Message-State: AOAM532KgHvB31uHPundn22FFLizgJ5o8MF0EW3WiQC3PVOeND9QiP9c gvwRDxZX93p1fdX+bLcyX9sR5Q== X-Google-Smtp-Source: ABdhPJy6bp8C1wfggIt0cRU76okfX2vFeGYaLqCkxWcLL3pwaky7370uXkBgC65bEOt7+KLhBK5Nag== X-Received: by 2002:a17:90a:bb82:: with SMTP id v2mr11607404pjr.57.1634110040417; Wed, 13 Oct 2021 00:27:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id fh3sm4933022pjb.8.2021.10.13.00.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 00:27:20 -0700 (PDT) Date: Wed, 13 Oct 2021 00:27:19 -0700 From: Kees Cook To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 05/10] asm-generic: Define 'funct_descr_t' to commonly describe function descriptors Message-ID: <202110130026.0AB963F82@keescook> References: <02224551451ab9c37055499fc621c41246c81125.1633964380.git.christophe.leroy@csgroup.eu> <202110130001.11A50456@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GbpddXjN; spf=pass (imf04.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4BB9650000B3 X-Stat-Signature: 51emsfzpobscxjqtwgdxwyaf4g9daoeo X-HE-Tag: 1634110041-945 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 09:23:56AM +0200, Christophe Leroy wrote: >=20 >=20 > Le 13/10/2021 =E0 09:01, Kees Cook a =E9crit=A0: > > On Mon, Oct 11, 2021 at 05:25:32PM +0200, Christophe Leroy wrote: > > > We have three architectures using function descriptors, each with i= ts > > > own name. > > >=20 > > > Add a common typedef that can be used in generic code. > > >=20 > > > Also add a stub typedef for architecture without function descripto= rs, > >=20 > > nit: funct_descr_t reads weird to me. why not func_desc_t ? Either wa= y: >=20 > func_desc_t already exists in powerpc. I have a patch to remove it as i= t is > redundant with struct ppc64_opd_entry, but I didnt' want to include it = in > this series. >=20 > But after all I can add it in this series, I'll add it in v2. Ah-ha! That works for me. :) Thanks! -Kees --=20 Kees Cook