From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06DB7C433EF for ; Wed, 13 Oct 2021 07:01:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9FB1D61039 for ; Wed, 13 Oct 2021 07:01:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9FB1D61039 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 44A21900002; Wed, 13 Oct 2021 03:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F9FB6B0071; Wed, 13 Oct 2021 03:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EA20900002; Wed, 13 Oct 2021 03:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 1FE126B006C for ; Wed, 13 Oct 2021 03:01:01 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D2F8518037FED for ; Wed, 13 Oct 2021 07:01:00 +0000 (UTC) X-FDA: 78690517080.03.D3DBF09 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf14.hostedemail.com (Postfix) with ESMTP id 985DF6001E6B for ; Wed, 13 Oct 2021 07:01:00 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id ls18so1447658pjb.3 for ; Wed, 13 Oct 2021 00:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=InasTA07olrN5RKyUCQ2QLJqu4RTKKj+4k1NAdmmjBE=; b=ZW1dzqTr/trhkOlzXVsWQL586M19ht5k71pAxPY8mwIv8HZ5vMO/WakCDu3Hq5RvP2 S4kwqQ46jwWgJmegTf1B7gmFx7ZY3FN7syR3QnvQaQXNPAkDoJZz1tg9c19yZdRE/ygR QKkc9RMEzFZzxIH9XcekZAMGkMKRcOFulbggU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=InasTA07olrN5RKyUCQ2QLJqu4RTKKj+4k1NAdmmjBE=; b=5VAs5dMLjO8OZvQku9/sEFYAqAdQQjiELJ/tCdpQ1MLXL+QX9ptsvWKLgitOJGLmIm cBzwXYaBldcDWTI5bunr5H0nApzCLohfPS1DdWG7hwMbDGC3znCZuFEPwKEX0fQ2Mc6B YYP9Ni0xLJhIfpN6nclH9Myq1CtHPCXMQXqJ0/g80xzGE07UiM9iEPlbob29yGwYbjkI b+5EL0FRPCm9cIW7cGKZegWVukNQxpO71o9RKlHnx/kQrDn3PnhxeHqXHes9jiEXzr/T KZTHCYNu81gTIQpSeXSJLP6imVyIW89FSH+bLmp6D81PZD8xfbFjrjnHGhHalaMH5Bqg pYew== X-Gm-Message-State: AOAM532q5eUbxTYBi4p11Lj1YkDdv6hAK1kzaCe+8/0F3HCgOhvsnIrZ W/YWd+ii08TZvX/eFT5hP7qR8Q== X-Google-Smtp-Source: ABdhPJy2g6jssV8McfoxTEnq7XQUmrF0dkkPaUlbhWhS4b/L/PDtLrRFbojWVXZaR7ZIvk9TuZJ6mw== X-Received: by 2002:a17:90a:5d11:: with SMTP id s17mr11474193pji.230.1634108459798; Wed, 13 Oct 2021 00:00:59 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m22sm13288608pfo.176.2021.10.13.00.00.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 00:00:59 -0700 (PDT) Date: Wed, 13 Oct 2021 00:00:58 -0700 From: Kees Cook To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 04/10] asm-generic: Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR to define associated stubs Message-ID: <202110122359.E59B90A@keescook> References: <8db2a3ca2b26a8325c671baa3e0492914597f079.1633964380.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8db2a3ca2b26a8325c671baa3e0492914597f079.1633964380.git.christophe.leroy@csgroup.eu> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 985DF6001E6B X-Stat-Signature: o8oirrjfydk6oa1ozga6bj7meqnihx7m Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZW1dzqTr; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.46 as permitted sender) smtp.mailfrom=keescook@chromium.org X-HE-Tag: 1634108460-408944 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 11, 2021 at 05:25:31PM +0200, Christophe Leroy wrote: > Use HAVE_DEREFERENCE_FUNCTION_DESCRIPTOR instead of 'dereference_function_descriptor' > to know whether arch has function descriptors. > > Signed-off-by: Christophe Leroy I'd mention the intentionally-empty #if/#else in the commit log, as I, like Helge, mentally tripped over it in the review. :) Reviewed-by: Kees Cook -- Kees Cook